Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

async_wrap: remove erroneous destroy list clear() #13353

Closed
wants to merge 1 commit into from

Commits on May 31, 2017

  1. async_wrap: remove erroneous destroy list clear()

    Remove a `.clear()` call on the list of destroy ids that may
    inadvertently swallow `destroy` events.
    
    The list is already cleared earlier in the `DestroyIdsCb` function,
    so usually this was a no-op; but when the garbage collection or
    its equivalent was active during a `destroy` hook itself, it was
    possible that `destroy` hooks were scheduled but cleared before the
    next event loop iteration in which they would have been emitted.
    
    Ref: nodejs#13286
    addaleax committed May 31, 2017
    Configuration menu
    Copy the full SHA
    a052d4a View commit details
    Browse the repository at this point in the history