Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: modernize and fix code examples in util.md #13298

Closed
wants to merge 3 commits into from
Closed

doc: modernize and fix code examples in util.md #13298

wants to merge 3 commits into from

Conversation

vsemozhetbyt
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt commented May 30, 2017 •
edited
Loading

Checklist
Affected core subsystem(s)

doc, util

  • Remove useless constructor.
  • Use template literals.
  • Update code example (now all arrays with just holes are outputted the same way; in this example, it is [ <101 empty items> ] twice).

@vsemozhetbyt
doc: remove useless constructor in util.md
1e46c08
@vsemozhetbyt
doc: use template literals in util.md
73d5495
@vsemozhetbyt
doc: update code example in util.md
dd02ded 
Now all arrays with holes only are outputted the same way.
In this example, it is `[ <101 empty items> ]` twice.
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. util Issues and PRs related to the built-in util module. labels May 30, 2017
@vsemozhetbyt
Copy link
Contributor Author

Linter CI: https://ci.nodejs.org/job/node-test-linter/9460/

mhdawson
mhdawson approved these changes May 30, 2017
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vsemozhetbyt
Copy link
Contributor Author

Landed in 862bf1b

@vsemozhetbyt vsemozhetbyt deleted the util.md branch June 1, 2017 14:50
vsemozhetbyt added a commit that referenced this pull request Jun 1, 2017
@vsemozhetbyt
doc: modernize and fix code examples in util.md
862bf1b 
* Remove useless constructor.

* Use template literals.

* Update code example.
  Now all arrays with just holes are outputted the same way.
  In the fixed example, it was `[ <101 empty items> ]` twice.

PR-URL: #13298
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell pushed a commit that referenced this pull request Jun 5, 2017
@vsemozhetbyt @jasnell
doc: modernize and fix code examples in util.md
561c14b 
* Remove useless constructor.

* Use template literals.

* Update code example.
  Now all arrays with just holes are outputted the same way.
  In the fixed example, it was `[ <101 empty items> ]` twice.

PR-URL: #13298
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell jasnell mentioned this pull request Jun 5, 2017
Closed
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vsemozhetbyt @jasnell @lpinca @mhdawson @MylesBorins @nodejs-github-bot