doc: make spelling of behavior consistent #13245
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the api docs there were some instances of behaviour and many more with behavior. I was asked as part of a review on a different PR which one to use and went with behavior to be consistent with the majority. Not sure if we should mandate the US or english spelling but this makes the api docs consistent.
aqrln
approved these changes
May 26, 2017
Contributor
aqrln
left a comment
aqrln
left a comment
There was a problem hiding this comment.
LGTM. STYLE_GUIDE.md explicitly states that we use American English spelling.
cjihrig
approved these changes
May 26, 2017
Member
|
There is one in https://github.com/nodejs/node/blob/master/doc/api/crypto.md that you might want to change. LGTM otherwise. |
Member
Author
|
@aqrln thanks, good to@ know that. @kunalspathak thanks. I'd used a grep but only with lower case, will add that one. |
Member
Author
|
Pushed commit to address comments so far. |
lpinca
approved these changes
May 27, 2017
targos
approved these changes
May 28, 2017
Member
|
Landed in 5b50501 |
targos
pushed a commit
that referenced
this pull request
May 28, 2017
In the api docs there were some instances of behaviour and many more with behavior. I was asked as part of a review on a different PR which one to use and went with behavior to be consistent with the majority. Our style guide states that American English spelling is preferred. PR-URL: #13245 Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Kunal Pathak <kunal.pathak@microsoft.com>
jasnell
pushed a commit
that referenced
this pull request
May 28, 2017
In the api docs there were some instances of behaviour and many more with behavior. I was asked as part of a review on a different PR which one to use and went with behavior to be consistent with the majority. Our style guide states that American English spelling is preferred. PR-URL: #13245 Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Kunal Pathak <kunal.pathak@microsoft.com>
3 tasks
MylesBorins
pushed a commit
that referenced
this pull request
Jul 17, 2017
In the api docs there were some instances of behaviour and many more with behavior. I was asked as part of a review on a different PR which one to use and went with behavior to be consistent with the majority. Our style guide states that American English spelling is preferred. PR-URL: #13245 Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Kunal Pathak <kunal.pathak@microsoft.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the api docs there were some instances of behaviour
and many more with behavior. I was asked as part of a review
on a different PR which one to use and went with behavior
to be consistent with the majority.
Not sure if we should mandate the US or english spelling but
this makes the api docs consistent.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
doc