src: remove unused node_buffer.h include #13095
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I can't find any usage of Buffer in this file and think the include can be removed.
nodejs-github-bot
added
c++
Contributor
Author
zimbabao
approved these changes
May 18, 2017
addaleax
approved these changes
May 18, 2017
cjihrig
approved these changes
May 18, 2017
danbev
added a commit
to danbev/node
that referenced
this pull request
May 22, 2017
I can't find any usage of Buffer in this file and think the include can be removed. PR-URL: nodejs#13095 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Contributor
Author
|
Landed in 7a15eef |
jasnell
pushed a commit
that referenced
this pull request
May 23, 2017
I can't find any usage of Buffer in this file and think the include can be removed. PR-URL: #13095 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
May 23, 2017
I can't find any usage of Buffer in this file and think the include can be removed. PR-URL: #13095 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
3 tasks
MylesBorins
pushed a commit
that referenced
this pull request
Jul 17, 2017
I can't find any usage of Buffer in this file and think the include can be removed. PR-URL: #13095 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can't find any usage of Buffer in this file and think the include can be
removed.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
src, crypto