Skip to content

test: improve net-immediate-finish-test #13062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

test: improve net-immediate-finish-test #13062

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e0c4e29
test: improve net-immediate-finish-test
vieiraarturg May 12, 2017
0122232
[squash] add comment
refack May 16, 2017
9e65d85
[squash] add comments and one more assert
refack May 16, 2017
fc9d8c8
[squash] add another assert
refack May 16, 2017
ba58f32
Sentence case
refack Jun 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions ...llel/test-net-connect-immediate-finish.js → ...tial/test-net-connect-immediate-finish.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,18 +21,31 @@

'use strict';
const common = require('../common');

// This test ensures that `net.connect` with an unfindable host will emit
// an error, and we assert the structure of the error.

const assert = require('assert');
const net = require('net');

const client = net.connect({host: '***', port: common.PORT});
// Since this test should fail with `ENOTFOUND` becuase of the unfindable host
// we don't care about the port, so we just pick an arbitrary but valid port.
const arbitrary_port = common.PORT
const unfindable_host = '***';
const client = net.connect({host: unfindable_host, port: arbitrary_port});

client.once('error', common.mustCall((err) => {
assert(err);
assert.ok(err);
assert.strictEqual(err.code, err.errno);
assert.strictEqual(err.code, 'ENOTFOUND');
assert.strictEqual(err.host, err.hostname);
assert.strictEqual(err.host, '***');
assert.strictEqual(err.host, unfindable_host);
assert.strictEqual(err.syscall, 'getaddrinfo');
assert.strictEqual(
err.message,
`getaddrinfo ENOTFOUND ${unfindable_host} ${unfindable_host}:${err.port}`
);
}));
client.on('connect', common.mustNotCall())

client.end();