Revert "test: remove eslint comments"#12743
Closed
joyeecheung wants to merge 1 commit intonodejs:masterfrom
Closed
Revert "test: remove eslint comments"#12743joyeecheung wants to merge 1 commit intonodejs:masterfrom
joyeecheung wants to merge 1 commit intonodejs:masterfrom
Conversation
This reverts commit 8d1f15b.
3 tasks
Member
Author
joyeecheung
added
the
whatwg-url
cjihrig
approved these changes
Apr 29, 2017
Contributor
|
I agree with the referenced comments that we should include some text saying not to modify and why. |
Trott
approved these changes
Apr 29, 2017
Member
Trott
left a comment
Trott
left a comment
There was a problem hiding this comment.
LGTM. Agree that adding a comment would be good to this and the other whatwg-url tests, but that should probably be a separate PR and let this one be a straightforward revert of a single commit.
watilde
approved these changes
Apr 30, 2017
jasnell
approved these changes
May 1, 2017
Member
Author
|
Landed in 9f7b549, thanks! |
anchnk
pushed a commit
to anchnk/node
that referenced
this pull request
May 6, 2017
This reverts commit 8d1f15b to preserve the original WPT code. PR-URL: nodejs#12743 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
3 tasks
Member
|
Reverts #12669, which was |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 8d1f15b to preserve the original WPT code.
Refs: https://github.com/nodejs/node/pull/12669/files/b2c7a51dd7542add59f08a8e9361ac4715c7f5ab#r114009488
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test, url-whatwg