Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

timers: cleanup interval handling #1272

Closed
wants to merge 2 commits into from
Closed

timers: cleanup interval handling #1272

wants to merge 2 commits into from

Commits on Mar 26, 2015

  1. timers: assure setTimeout callback only runs once 

    Calling this.unref() during the callback of SetTimeout caused the
callback to get executed twice because unref() didn't expect to be
called during that time and did not stop the ref()ed Timeout but
did start a new timer. This commit prevents the new timer creation
when the callback was already called.

Fixes: nodejs#1191
Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
PR_URL: nodejs#1231
    @silverwind
    silverwind committed Mar 26, 2015
    1 Configuration menu
    Copy the full SHA
    b0f8e30 View commit details
    Browse the repository at this point in the history

  2. timers: cleanup interval handling 

    Uses `null` as the false-y value for `_repeat` as like other properties.
Removes un-reachable statement in setInterval’s `wrapper()`.

PR-URL: nodejs#1272
Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    @Fishrock123
    Fishrock123 committed Mar 26, 2015
    Configuration menu
    Copy the full SHA
    bb2a99b View commit details
    Browse the repository at this point in the history