test: cleanup test-utils-inherits.js #12602
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bengl
added
the
code-and-learn
addaleax
approved these changes
Apr 22, 2017
cjihrig
approved these changes
Apr 22, 2017
|
Commit message should say 'test-util-inherits' (singular). |
Replaced constructor with regular expression for assert.throw().
RobotMermaid
force-pushed
the
fixup-test-util-inherits
branch
from
12085be
to
888d1c1
Compare
|
Linux CI issues are unrelated. CI looks good. |
santigimeno
approved these changes
Apr 24, 2017
jasnell
requested changes
Apr 24, 2017
test/parallel/test-util-inherits.js
Outdated
| }, /^TypeError: The super constructor to "inherits" must have a prototype$/); | ||
| assert.throws(function() { | ||
| inherits(A, null); | ||
| }, /^TypeError: The super constructor to "inherits" must not be null or undefined$/); // eslint-disable-line max-len |
There was a problem hiding this comment.
Long line here. Lines should not be longer than 80 chars
There was a problem hiding this comment.
Specifically, I know this inlines the eslint rule, but this can be reworked to avoid that entirely...
const errCheck =
new RegExp('^TypeError: The super constructor to "inherits" must not be ' +
'null or undefined$');
assert.throws(() => inherits(A, null), errCheck);Replaced constructor with regular expression for assert.throw().
Replaced constructor with regular expression for assert.throw().
jasnell
approved these changes
Apr 24, 2017
|
GitHub reports no merge conflict but CI can't do a checkout because of a merge conflict. I think I've seen this before with a merge commit or something? Anyone remember what's going on? @nodejs/build |
|
@Trott I think the issue is that when squashed together, the commits here don’t generate a merge conflict, but the partial ones do. I think this is good as-is, the only change since the last CI seems to be moving code around for linting, and this isn’t a platform-dependent test anyway. |
|
Landed in 2055fd3, thank you a lot for the PR! |
addaleax
pushed a commit
that referenced
this pull request
Apr 27, 2017
Replaced constructor with regular expression for assert.throw(). PR-URL: #12602 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
evanlucas
pushed a commit
that referenced
this pull request
May 1, 2017
Replaced constructor with regular expression for assert.throw(). PR-URL: #12602 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
May 2, 2017
Replaced constructor with regular expression for assert.throw(). PR-URL: #12602 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
May 2, 2017
Replaced constructor with regular expression for assert.throw(). PR-URL: #12602 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
gibfahn
pushed a commit
that referenced
this pull request
May 15, 2017
Replaced constructor with regular expression for assert.throw(). PR-URL: #12602 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
andrew749
pushed a commit
to michielbaird/node
that referenced
this pull request
Jul 19, 2017
Replaced constructor with regular expression for assert.throw(). PR-URL: nodejs/node#12602 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced constructor with regular expression for assert.throw().
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)