Skip to content

test: improved type checking with regex#12591

Closed
b6t wants to merge 1 commit intonodejs:masterfrom
b6t:csb
Closed

test: improved type checking with regex#12591
b6t wants to merge 1 commit intonodejs:masterfrom
b6t:csb

Conversation

@b6t
Copy link

@b6t b6t commented Apr 22, 2017

Removed generic check of TypeError and replaced with a regular expression of the expected error message.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

test: improved type checking with regex
095f552 
Replaced TypeError with a regular expression of the actual error.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Apr 22, 2017
@Trott Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Apr 22, 2017
@Trott
Copy link
Member

Trott commented Apr 22, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/7590/

@mscdex mscdex added the net Issues and PRs related to the net subsystem. label Apr 22, 2017
Trott
Trott approved these changes Apr 22, 2017
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green

Trott pushed a commit to Trott/io.js that referenced this pull request Apr 26, 2017
@Trott
test: improved type checking with regex
e8004db 
Replaced TypeError with a regular expression of the actual error.

PR-URL: nodejs#12591
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott
Copy link
Member

Trott commented Apr 26, 2017

Landed in e8004db.
Thanks for the contribution! 🎉

@Trott Trott closed this Apr 26, 2017
@evanlucas evanlucas mentioned this pull request May 1, 2017
Merged
evanlucas pushed a commit that referenced this pull request May 1, 2017
@evanlucas
test: improved type checking with regex
37c0f27 
Replaced TypeError with a regular expression of the actual error.

PR-URL: #12591
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas pushed a commit that referenced this pull request May 2, 2017
@evanlucas
test: improved type checking with regex
1a84f06 
Replaced TypeError with a regular expression of the actual error.

PR-URL: #12591
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas pushed a commit that referenced this pull request May 2, 2017
@evanlucas
test: improved type checking with regex
660e58c 
Replaced TypeError with a regular expression of the actual error.

PR-URL: #12591
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 15, 2017
@MylesBorins
test: improved type checking with regex
89e76e8 
Replaced TypeError with a regular expression of the actual error.

PR-URL: #12591
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request May 23, 2017
Merged
@shigeki shigeki mentioned this pull request Jun 16, 2017
Closed
4 tasks
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
@andrew749
test: improved type checking with regex
d7402d6 
Replaced TypeError with a regular expression of the actual error.

PR-URL: nodejs/node#12591
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@snyk-bot snyk-bot mentioned this pull request Mar 18, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Apr 1, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@santigimeno santigimeno santigimeno approved these changes

@cjihrig cjihrig cjihrig approved these changes

+2 more reviewers

@Fishrock123 Fishrock123 Fishrock123 approved these changes

@gibfahn gibfahn gibfahn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. net Issues and PRs related to the net subsystem. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@b6t @Trott @jasnell @santigimeno @Fishrock123 @cjihrig @gibfahn @mscdex @MylesBorins @nodejs-github-bot