test: increase coverage for buffer.js #12476
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
added
buffer
cjihrig
approved these changes
Apr 17, 2017
Contributor
cjihrig
left a comment
cjihrig
left a comment
There was a problem hiding this comment.
Not sure if byteoffset in the comment should be byteOffset, but either way, LGTM.
jasnell
requested changes
Apr 18, 2017
Member
There was a problem hiding this comment.
This is fine, but it may be worthwhile to test additional non-numeric inputs (object, array, NaN, etc).
For instance:
Buffer.from(ab, NaN),offsetdefaults to0Buffer.from(ab, Infinity)throwsBuffer.from(ab, {})offsetdefaults to0Buffer.from(ab, [])offsetdefaults to0Buffer.from(ab, [1])``offset is1
etc...
Member
Author
There was a problem hiding this comment.
Added these. PTAL. Thanks.
Add coverage for non-numeric byteOffset and length when using Buffer.from() with an ArrayBuffer.
Member
Author
|
@cjihrig Updated the comment. Thanks. |
Member
Author
jasnell
approved these changes
Apr 18, 2017
Member
|
Failure in CI is unrelated. |
jasnell
pushed a commit
that referenced
this pull request
Apr 19, 2017
Add coverage for non-numeric byteOffset and length when using Buffer.from() with an ArrayBuffer. PR-URL: #12476 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
LAnded in d78fd26 |
evanlucas
pushed a commit
that referenced
this pull request
Apr 25, 2017
Add coverage for non-numeric byteOffset and length when using Buffer.from() with an ArrayBuffer. PR-URL: #12476 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
evanlucas
pushed a commit
that referenced
this pull request
May 1, 2017
Add coverage for non-numeric byteOffset and length when using Buffer.from() with an ArrayBuffer. PR-URL: #12476 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
May 2, 2017
Add coverage for non-numeric byteOffset and length when using Buffer.from() with an ArrayBuffer. PR-URL: #12476 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
gibfahn
pushed a commit
that referenced
this pull request
May 16, 2017
Add coverage for non-numeric byteOffset and length when using Buffer.from() with an ArrayBuffer. PR-URL: #12476 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
May 18, 2017
Add coverage for non-numeric byteOffset and length when using Buffer.from() with an ArrayBuffer. PR-URL: #12476 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
andrew749
pushed a commit
to michielbaird/node
that referenced
this pull request
Jul 19, 2017
Add coverage for non-numeric byteOffset and length when using Buffer.from() with an ArrayBuffer. PR-URL: nodejs/node#12476 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add coverage for non-numeric byteOffset and length when using
Buffer.from() with an ArrayBuffer.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test buffer