Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate cluster tests from common.PORT #12441

Closed
wants to merge 1 commit into from
Closed

Migrate cluster tests from common.PORT #12441

wants to merge 1 commit into from

Conversation

tarunbatra
Copy link
Contributor

Migrate the following test files away from common.PORT:

  • test-cluster-disconnect-leak.js
  • test-cluster-disconnect-race.js
  • test-cluster-process-disconnect.js

Ref: #12376

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

tests

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Apr 16, 2017
@mscdex mscdex added the cluster Issues and PRs related to the cluster subsystem. label Apr 16, 2017
Trott
Trott approved these changes Apr 16, 2017
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green.

@Trott
Copy link
Member

Trott commented Apr 16, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/7426/

@Trott Trott mentioned this pull request Apr 16, 2017
Closed
64 tasks
@tarunbatra
Copy link
Contributor Author

@Trott It's green! 🎉

@gibfahn
Copy link
Member

gibfahn commented Apr 16, 2017

Could you trim your commit message subjects to <50 chars as per the Contributing Guidelines?

You could also probably just make this one commit, as it's one change made to three files.

Maybe something like this?

test: remove common.PORT from cluster tests

@tarunbatra
Copy link
Contributor Author

@gibfahn Done!

@jasnell
Copy link
Member

jasnell commented Apr 18, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/7483/

jasnell pushed a commit that referenced this pull request Apr 18, 2017
@tarunbatra @jasnell
test: remove common.PORT from test-cluster*.js
415098f 
PR-URL: #12441
Ref: #12376
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Apr 18, 2017

Landed in 415098f

@jasnell jasnell closed this Apr 18, 2017
evanlucas pushed a commit that referenced this pull request Apr 25, 2017
@tarunbatra @evanlucas
test: remove common.PORT from test-cluster*.js
c75dd8b 
PR-URL: #12441
Ref: #12376
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@evanlucas evanlucas mentioned this pull request May 1, 2017
Merged
evanlucas pushed a commit that referenced this pull request May 1, 2017
@tarunbatra @evanlucas
test: remove common.PORT from test-cluster*.js
ad7c1c6 
PR-URL: #12441
Ref: #12376
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas pushed a commit that referenced this pull request May 2, 2017
@tarunbatra @evanlucas
test: remove common.PORT from test-cluster*.js
a7e13e0 
PR-URL: #12441
Ref: #12376
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
gibfahn pushed a commit that referenced this pull request May 16, 2017
@tarunbatra @gibfahn
test: remove common.PORT from test-cluster*.js
08833f3 
PR-URL: #12441
Ref: #12376
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 18, 2017
@tarunbatra @MylesBorins
test: remove common.PORT from test-cluster*.js
3244ae3 
PR-URL: #12441
Ref: #12376
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request May 23, 2017
Merged
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
@tarunbatra @andrew749
test: remove common.PORT from test-cluster*.js
eedba1c 
PR-URL: nodejs/node#12441
Ref: nodejs/node#12376
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gibfahn gibfahn gibfahn approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@benjamingr benjamingr benjamingr approved these changes

@santigimeno santigimeno santigimeno approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
cluster Issues and PRs related to the cluster subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@tarunbatra @Trott @gibfahn @jasnell @santigimeno @benjamingr @lpinca @cjihrig @mscdex @nodejs-github-bot