Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: replace [].join() with ''.repeat() #12305

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/parallel/test-child-process-send-utf8.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ const common = require('../common');
const assert = require('assert');
const fork = require('child_process').fork;

const expected = Array(1e5).join('ßßßß');
const expected = 'ßßßß'.repeat(1e5 - 1);
if (process.argv[2] === 'child') {
process.send(expected);
} else {
Expand Down
8 changes: 4 additions & 4 deletions test/parallel/test-stringbytes-external.js
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,9 @@ assert.strictEqual(b[1], 0);
assert.strictEqual(ucs2_control, c);

// now create big strings
const size = 1 + (1 << 20);
write_str = Array(size).join(write_str);
ucs2_control = Array(size).join(ucs2_control);
const size = 1 << 20;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary to change size in this PR?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you do the Array.join() it ends up as one less than size, so when you move to repeat you have to decrease size by one to get the same string length.

> Array(3).join('a')
'aa'
> 'a'.repeat(3)
'aaa'

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see. Thanks.

write_str = write_str.repeat(size);
ucs2_control = ucs2_control.repeat(size);

// check resultant buffer and output string
b = Buffer.from(write_str, 'ucs2');
Expand Down Expand Up @@ -131,7 +131,7 @@ const PRE_3OF4_APEX = Math.ceil((EXTERN_APEX / 4) * 3) - RADIOS;

// https://github.com/nodejs/node/issues/1024
{
const a = Array(1 << 20).join('x');
const a = 'x'.repeat(1 << 20 - 1);
const b = Buffer.from(a, 'ucs2').toString('ucs2');
const c = Buffer.from(b, 'utf8').toString('utf8');

Expand Down