Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add refack to collaborators #12277

Closed
wants to merge 1 commit into from
Closed

Conversation

refack
Copy link
Contributor

@refack refack commented Apr 7, 2017

Checklist
  • documentation is changed or added
  • commit message follows [commit guidelines]
Affected core subsystem(s)

doc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 7, 2017
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@refack
Copy link
Contributor Author

refack commented Apr 7, 2017

refack added a commit to refack/node that referenced this pull request Apr 7, 2017
PR-URL: nodejs#12277
Refs: https://github.com/nodejs/node/blob/master/doc/onboarding.md
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
@refack refack closed this Apr 7, 2017
@refack
Copy link
Contributor Author

refack commented Apr 7, 2017

Landed in ca8ccb9

@refack refack deleted the add_refack branch April 7, 2017 22:31
@Trott Trott added the notable-change PRs with changes that should be highlighted in changelogs. label Apr 9, 2017
italoacasas pushed a commit to italoacasas/node that referenced this pull request Apr 10, 2017
PR-URL: nodejs#12277
Refs: https://github.com/nodejs/node/blob/master/doc/onboarding.md
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
@italoacasas italoacasas mentioned this pull request Apr 10, 2017
2 tasks
MylesBorins pushed a commit that referenced this pull request Apr 18, 2017
PR-URL: #12277
Refs: https://github.com/nodejs/node/blob/master/doc/onboarding.md
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 19, 2017
PR-URL: #12277
Refs: https://github.com/nodejs/node/blob/master/doc/onboarding.md
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Apr 19, 2017
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
PR-URL: nodejs/node#12277
Refs: https://github.com/nodejs/node/blob/master/doc/onboarding.md
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. notable-change PRs with changes that should be highlighted in changelogs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants