doc: fix fs.read arg type and setImmediate desc#12034
Closed
darai0512 wants to merge 2 commits intonodejs:masterfrom
Closed
doc: fix fs.read arg type and setImmediate desc#12034darai0512 wants to merge 2 commits intonodejs:masterfrom
darai0512 wants to merge 2 commits intonodejs:masterfrom
Conversation
Contributor
|
I may be wrong, but is it worth to be split into separate commits or even PRs? |
Contributor
Author
|
@vsemozhetbyt |
lpinca
approved these changes
Mar 26, 2017
About fs.read's 2nd argument, string is invalid.
About setImmediate, the execution timing is after timers currently.
Contributor
Author
|
@vsemozhetbyt |
vsemozhetbyt
approved these changes
Mar 26, 2017
hiroppy
approved these changes
Mar 26, 2017
jasnell
approved these changes
Mar 26, 2017
Member
|
@Fishrock... are you good with the Timers doc change here? |
addaleax
approved these changes
Mar 31, 2017
Member
addaleax
left a comment
There was a problem hiding this comment.
^^^ That ping should probably have gone to @Fishrock123 ;)
jasnell
pushed a commit
that referenced
this pull request
Apr 4, 2017
About fs.read's 2nd argument, string is invalid. PR-URL: #12034 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
jasnell
pushed a commit
that referenced
this pull request
Apr 4, 2017
About setImmediate, the execution timing is after timers currently. PR-URL: #12034 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Member
|
Landed in 0844262...e9f2ec4 |
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Apr 10, 2017
About fs.read's 2nd argument, string is invalid. PR-URL: nodejs#12034 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Apr 10, 2017
About setImmediate, the execution timing is after timers currently. PR-URL: nodejs#12034 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Contributor
|
is this accurate for v6.x? |
3 tasks
Member
ping |
Contributor
Author
|
@MylesBorins @gibfahn |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description of change
About fs.read's 2nd argument, I think string is invalid.
https://github.com/nodejs/node/blob/v6.x-staging/src/node_file.cc#L1247-L1248
And also, about setImmediate, the timing of the execution is after timers in Event Loop of over v0.9, though it is correct in Event Loop under v0.8.
So, I deleted the description because the timing depended on Nodejs version.