benchmark: update obsolete information pointer #12026
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A doc suggested in an error message is no longer the place to get the information about required http benchmarkers. Update the error message to point to the current location for the information.
|
Pre-emptive comment: This isn't semver-major because the error message that is being changed is in our dev tooling, not in the Node.js end product. |
|
Pre-emptive comment no. 2: The long line does not cause the linter to complain because the linter is configured to make exceptions for URLs. That's specifically for cases like this where splitting up that URL just to keep the line under 80 characters is far worse than just having that one line extend out longer than all the other lines. |
|
Gratuitous CI run (only the lint results matter as far as I know, but just in case I'm wrong about that and this file does get exercised somehow on CI...): https://ci.nodejs.org/job/node-test-pull-request/7026/ |
jasnell
approved these changes
Mar 24, 2017
cjihrig
approved these changes
Mar 25, 2017
lpinca
approved these changes
Mar 25, 2017
fhinkel
approved these changes
Mar 26, 2017
|
Landed in 874b6b9 |
fhinkel
pushed a commit
that referenced
this pull request
Mar 26, 2017
A doc suggested in an error message is no longer the place to get the information about required http benchmarkers. Update the error message to point to the current location for the information. PR-URL: #12026 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 28, 2017
A doc suggested in an error message is no longer the place to get the information about required http benchmarkers. Update the error message to point to the current location for the information. PR-URL: #12026 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A doc suggested in an error message is no longer the place to get the
information about required http benchmarkers. Update the error message
to point to the current location for the information.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
benchmark