test: add internal/socket_list tests#11989
Closed
DavidCai1111 wants to merge 1 commit intonodejs:masterfrom
Closed
test: add internal/socket_list tests#11989DavidCai1111 wants to merge 1 commit intonodejs:masterfrom
DavidCai1111 wants to merge 1 commit intonodejs:masterfrom
Conversation
mscdex
added
the
child_process
jasnell
approved these changes
Mar 22, 2017
Contributor
jasnell
pushed a commit
that referenced
this pull request
Mar 24, 2017
PR-URL: #11989 Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
Landed in 4929d12 |
Contributor
|
These tests are currently failing on v7.x and will need to be manually backported |
Member
Author
|
OK, I'll submit another PR to backport it. |
3 tasks
3 tasks
Member
|
Landed b997e62 on v6.x-staging, LMK if I shouldn't have. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tests of
internal/socket_list.jsand increase its coverage.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test