Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Add node-inspect 1.10.6 #11869

Closed
wants to merge 2 commits into from
Closed

deps: Add node-inspect 1.10.6 #11869

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c3ded73
deps: Add node-inspect 1.10.6
Mar 15, 2017
43bd1db
lib: Fix swallowed events in inspect integration
Mar 15, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
lib: Fix swallowed events in inspect integration
  • Loading branch information
Jan Krems committed Mar 15, 2017
commit 43bd1dba0ca1d5a4cd4a26ee46f005cf5c1daefe
4 changes: 3 additions & 1 deletion lib/internal/bootstrap_node.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,9 @@

} else if (process.argv[1] === 'inspect') {
// Start the debugger agent
NativeModule.require('node-inspect/lib/_inspect').start();
process.nextTick(function() {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This hack appear in multiple places in bootstrap. What I saw before adding it: The pingPort function calls net.connect and setTimeout. Unless the latter was removed or moved to the next tick, none of the connect events would ever fire.

NativeModule.require('node-inspect/lib/_inspect').start();
});

} else if (process.argv[1] === '--remote_debugging_server') {
// Start the debugging server
Expand Down