Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix flaky test-http-set-timeout-server #11790

Merged
merged 1 commit into from
Mar 14, 2017
Merged

test: fix flaky test-http-set-timeout-server #11790

merged 1 commit into from
Mar 14, 2017

Commits on Mar 14, 2017

  1. test: fix flaky test-http-set-timeout-server 

    It can happen that the connection and server is closed before the second
reponse has been processed by server. In this case, the
`res.setTimeout()` callback will never be called causing the test to
fail. Fix this by only closing the connection and server when the 2nd
has been received.

PR-URL: nodejs#11790
Fixes: nodejs#11768
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    @santigimeno
    santigimeno committed Mar 14, 2017
    Configuration menu
    Copy the full SHA
    3be1db8 View commit details
    Browse the repository at this point in the history