Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linkedlist: remove unused methods #11726

Closed
wants to merge 1 commit into from
Closed

linkedlist: remove unused methods #11726

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions lib/internal/linkedlist.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,26 +5,12 @@ function init(list) {
list._idlePrev = list;
}

// create a new linked list
function create() {
const list = { _idleNext: null, _idlePrev: null };
init(list);
return list;
}

// show the most idle item
function peek(list) {
if (list._idlePrev === list) return null;
return list._idlePrev;
}

// remove the most idle item from the list
function shift(list) {
const first = list._idlePrev;
remove(first);
return first;
}

// remove a item from its list
function remove(item) {
if (item._idleNext) {
Expand Down Expand Up @@ -61,9 +47,7 @@ function isEmpty(list) {

module.exports = {
init,
create,
peek,
shift,
remove,
append,
isEmpty
Expand Down
36 changes: 7 additions & 29 deletions test/parallel/test-timers-linked-list.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,14 +41,8 @@ L.append(list, D);
// list -> A -> B -> C -> D
assert.strictEqual(A, L.peek(list));

assert.strictEqual(A, L.shift(list));
// list -> B -> C -> D
assert.strictEqual(B, L.peek(list));

assert.strictEqual(B, L.shift(list));
// list -> C -> D
assert.strictEqual(C, L.peek(list));

L.remove(A);
L.remove(B);
// B is already removed, so removing it again shouldn't hurt.
L.remove(B);
// list -> C -> D
Expand Down Expand Up @@ -86,26 +80,10 @@ L.append(list, A);

// Append should REMOVE C from the list and append it to the end.
L.append(list, C);

// list -> D -> B -> A -> C
assert.strictEqual(D, L.shift(list));
// list -> B -> A -> C
assert.strictEqual(B, L.peek(list));
assert.strictEqual(B, L.shift(list));
// list -> A -> C
assert.strictEqual(A, L.peek(list));
assert.strictEqual(A, L.shift(list));
// list -> C
assert.strictEqual(C, L.peek(list));
assert.strictEqual(C, L.shift(list));
// list
assert.ok(L.isEmpty(list));

const list2 = L.create();
const list3 = L.create();
assert.ok(L.isEmpty(list2));
assert.ok(L.isEmpty(list3));

// Objects should have identical keys/properties, but be different objects.
assert.deepStrictEqual(list2, list3);
assert.notStrictEqual(list2, list3);
assert.strictEqual(D, L.peek(list));
assert.strictEqual(B, L.peek(D));
assert.strictEqual(A, L.peek(B));
assert.strictEqual(C, L.peek(A));
assert.strictEqual(list, L.peek(C));