Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v6.x: deps: backport dfb8d33 from V8 upstream #11483

Closed
wants to merge 2 commits into from
Closed

v6.x: deps: backport dfb8d33 from V8 upstream #11483

wants to merge 2 commits into from

Commits on Mar 3, 2017

  1. deps: backport dfb8d33 from V8 upstream 

    Original commit message:
    Reduce the memory footprint of expression classifiers

    This patch attempts to reduce the (stack) memory footprint of
    expression classifiers.  Instead of keeping space in each
    classifier for all possible error messages that will
    (potentially) be reported, if an expression turns out to be
    a pattern or a non-pattern, such error messages are placed in
    a list shared by the FunctionState and each classifier keeps a
    couple of indices in this list.  This requires that classifiers
    are used strictly in a stack-based fashion, which is also in line
    with my previous patch for revisiting non-pattern rewriting.

    R=adamk@chromium.org
    BUG=chromium:528697

    Review-Url: https://codereview.chromium.org/1708193003
    Cr-Commit-Position: refs/heads/master@{nodejs#36897}

Fixes: nodejs#11480
    @targos
    targos committed Mar 3, 2017
    Configuration menu
    Copy the full SHA
    b858d69 View commit details
    Browse the repository at this point in the history

  2. test: add regression test for V8 parse error 

    Refs: nodejs#11480
    @targos
    targos committed Mar 3, 2017
    Configuration menu
    Copy the full SHA
    6b34806 View commit details
    Browse the repository at this point in the history