domain,events: support non-object 'error' argument #11438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
events
addaleax
approved these changes
Feb 17, 2017
|
I extended the test coverage from just strings to other primitives. It's a little awkward though: truthy values are passed through as-is while falsy values are replaced with an Error object. But hey, it's backwards compatible. |
cjihrig
approved these changes
Feb 17, 2017
jasnell
approved these changes
Feb 17, 2017
Fix a TypeError when emitting an 'error' argument with a non-object argument (like a string) when domains are active. Fixes: nodejs/help#501 PR-URL: nodejs#11438 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
bnoordhuis
force-pushed
the
fix-help-501
branch
from
136f234
to
4f638f6
Compare
addaleax
pushed a commit
that referenced
this pull request
Feb 24, 2017
Fix a TypeError when emitting an 'error' argument with a non-object argument (like a string) when domains are active. Fixes: nodejs/help#501 PR-URL: #11438 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
|
This will need a backport PR to land in v6 and v4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a TypeError when emitting an 'error' argument with a non-object
argument (like a string) when domains are active.
Refs: nodejs/help#501