Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update link to V8 Embedder's guide #11336

Closed
wants to merge 1 commit into from
Closed

doc: update link to V8 Embedder's guide #11336

wants to merge 1 commit into from

Conversation

fhinkel
Copy link
Member

@fhinkel fhinkel commented Feb 13, 2017

V8 moved the Embeder's guide to GitHub.

Checklist
  • documentation is changed or added
Affected core subsystem(s)

doc

@fhinkel
doc: update link to V8 Embedder's guide
b4e5dd4 
V8 moved the Embeder's guide to GitHub.
@fhinkel fhinkel added the doc Issues and PRs related to the documentations. label Feb 13, 2017
jasnell
jasnell approved these changes Feb 13, 2017
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't need the full 48 hours to land

fhinkel added a commit to fhinkel/node that referenced this pull request Feb 14, 2017
@fhinkel
doc: update link to V8 Embedder's guide
76ba3bf 
V8 moved the Embeder's guide to GitHub.

PR-URL: nodejs#11336
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@fhinkel
Copy link
Member Author

fhinkel commented Feb 14, 2017

Landed in 76ba3bf

@fhinkel fhinkel closed this Feb 14, 2017
italoacasas pushed a commit to italoacasas/node that referenced this pull request Feb 14, 2017
@fhinkel @italoacasas
doc: update link to V8 Embedder's guide
2f1ce29 
V8 moved the Embeder's guide to GitHub.

PR-URL: nodejs#11336
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@italoacasas italoacasas mentioned this pull request Feb 14, 2017
Merged
jasnell pushed a commit that referenced this pull request Mar 7, 2017
@fhinkel @jasnell
doc: update link to V8 Embedder's guide
69fe507 
V8 moved the Embeder's guide to GitHub.

PR-URL: #11336
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@fhinkel @MylesBorins
doc: update link to V8 Embedder's guide
7df4ee8 
V8 moved the Embeder's guide to GitHub.

PR-URL: #11336
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@fhinkel @bnoordhuis @jasnell @lpinca @targos @cjihrig