Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove duplicated word in comment #11323

Closed
wants to merge 1 commit into from
Closed

remove duplicated word in comment #11323

wants to merge 1 commit into from

Conversation

asafdav2
Copy link
Contributor

Checklist
  • commit message follows commit guidelines
Affected core subsystem(s)

@nodejs-github-bot nodejs-github-bot added the timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. label Feb 12, 2017
@asafdav2 asafdav2 changed the title remove duplicated word remove duplicated word in comment Feb 12, 2017
@mscdex
Copy link
Contributor

mscdex commented Feb 12, 2017

LGTM

jasnell
jasnell approved these changes Feb 12, 2017
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't need to wait the 48 hours to land

@hiroppy
Copy link
Member

hiroppy commented Feb 12, 2017

Landed in b2a7765.

@hiroppy hiroppy closed this Feb 12, 2017
hiroppy pushed a commit that referenced this pull request Feb 12, 2017
@asafdav2 @hiroppy
timer: remove duplicated word in comment
b2a7765 
PR-URL: #11323
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Feb 14, 2017
@asafdav2 @italoacasas
timer: remove duplicated word in comment
e4b139d 
PR-URL: nodejs#11323
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
@italoacasas italoacasas mentioned this pull request Feb 14, 2017
Merged
krydos pushed a commit to krydos/node that referenced this pull request Feb 25, 2017
@asafdav2 @krydos
timer: remove duplicated word in comment
65dbd23 
PR-URL: nodejs#11323
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
jasnell pushed a commit that referenced this pull request Mar 7, 2017
@asafdav2 @jasnell
timer: remove duplicated word in comment
49dfa89 
PR-URL: #11323
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@asafdav2 @MylesBorins
timer: remove duplicated word in comment
b90a141 
PR-URL: #11323
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Merged
@joyeecheung joyeecheung mentioned this pull request Mar 28, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiroppy hiroppy hiroppy approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@thefourtheye thefourtheye thefourtheye approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@asafdav2 @mscdex @hiroppy @jasnell @thefourtheye @TimothyGu @nodejs-github-bot