Skip to content

test: increase specificity in dgram test #11187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

test: increase specificity in dgram test #11187

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Feb 5, 2017

Expand error message checking to include the entire error string in
test-dgram-membership.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test dgram

@Trott
test: increase specificity in dgram test
362a161 
Expand error message checking to include the entire error string in
test-dgram-membership.
@Trott Trott added dgram Issues and PRs related to the dgram subsystem / UDP. test Issues and PRs related to the tests. labels Feb 5, 2017
@hiroppy
Copy link
Member

hiroppy commented Feb 6, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/6232/

@Trott
Copy link
Member Author

Trott commented Feb 7, 2017

CI again: https://ci.nodejs.org/job/node-test-pull-request/6264/

Trott added a commit to Trott/io.js that referenced this pull request Feb 8, 2017
@Trott
test: increase specificity in dgram test
73f219f 
Expand error message checking to include the entire error string in
test-dgram-membership.

PR-URL: nodejs#11187
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott
Copy link
Member Author

Trott commented Feb 8, 2017

Landed in 73f219f

@Trott Trott closed this Feb 8, 2017
italoacasas pushed a commit to italoacasas/node that referenced this pull request Feb 9, 2017
@Trott
test: increase specificity in dgram test
343c041 
Expand error message checking to include the entire error string in
test-dgram-membership.

PR-URL: nodejs#11187
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@italoacasas italoacasas mentioned this pull request Feb 13, 2017
Merged
italoacasas pushed a commit to italoacasas/node that referenced this pull request Feb 14, 2017
@Trott
test: increase specificity in dgram test
b766dab 
Expand error message checking to include the entire error string in
test-dgram-membership.

PR-URL: nodejs#11187
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
krydos pushed a commit to krydos/node that referenced this pull request Feb 25, 2017
@Trott @krydos
test: increase specificity in dgram test
964d402 
Expand error message checking to include the entire error string in
test-dgram-membership.

PR-URL: nodejs#11187
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
jasnell pushed a commit that referenced this pull request Mar 7, 2017
@Trott @jasnell
test: increase specificity in dgram test
888ca4a 
Expand error message checking to include the entire error string in
test-dgram-membership.

PR-URL: #11187
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
jasnell pushed a commit that referenced this pull request Mar 7, 2017
@Trott @jasnell
test: increase specificity in dgram test
94c4ce9 
Expand error message checking to include the entire error string in
test-dgram-membership.

PR-URL: #11187
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@Trott @MylesBorins
test: increase specificity in dgram test
28111f9 
Expand error message checking to include the entire error string in
test-dgram-membership.

PR-URL: #11187
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@Trott @MylesBorins
test: increase specificity in dgram test
c532c16 
Expand error message checking to include the entire error string in
test-dgram-membership.

PR-URL: #11187
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Merged
@Trott Trott deleted the dgram-moar branch January 13, 2022 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

+2 more reviewers

@thefourtheye thefourtheye thefourtheye approved these changes

@hiroppy hiroppy hiroppy approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
dgram Issues and PRs related to the dgram subsystem / UDP. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Trott @hiroppy @jasnell @thefourtheye @lpinca @cjihrig