Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test, url: updated assertions in url-searchparams-getall tests #11142

Closed
wants to merge 2 commits into from
Closed

test, url: updated assertions in url-searchparams-getall tests #11142

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05cea2d
test, url: updated assertions in url-searchparams-getall tests
IvanJov Feb 3, 2017
0db818b
Fixed lint problems
IvanJov Feb 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions test/parallel/test-whatwg-url-searchparams-getall.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,15 +25,17 @@ test(function() {

test(function() {
var params = new URLSearchParams('a=1&a=2&a=3&a');
assert_true(params.has('a'), 'Search params object has name "a"');
assert_true(params.has('a'), `Search params object doesn't have name "a"`);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will not pass make lint given that it is a plain string without any replacements. Please simply avoid the use of the contraction and make it a normal string.. e.g. 'Search params object does not have name "a"'.

Copy link
Author

@IvanJov IvanJov Feb 3, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, tested with make lint.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We disable eslint for WPT tests though, because the styles are too different.. :D

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still better to keep it consistent

var matches = params.getAll('a');
assert_true(matches && matches.length == 4, 'Search params object has values for name "a"');
assert_array_equals(matches, ['1', '2', '3', ''], 'Search params object has expected name "a" values');
assert(matches);
assert_equals(matches.length, 4, `Unexpected length of name "a" values in search params object: ${matches.length}`);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please line wrap at 80 chars

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in separate commit, I can squash them at the end.

assert_array_equals(matches, ['1', '2', '3', ''], `Unexpected name "a" values: ${matches}`);
params.set('a', 'one');
assert_equals(params.get('a'), 'one', 'Search params object has name "a" with value "one"');
var matches = params.getAll('a');
assert_true(matches && matches.length == 1, 'Search params object has values for name "a"');
assert_array_equals(matches, ['one'], 'Search params object has expected name "a" values');
assert_equals(params.get('a'), 'one', `Search params object doesn't have name "a" with value "one"`);
matches = params.getAll('a');
assert(matches);
assert_equals(matches.length, 1, `Unexpected length of name "a" values in search params object: ${matches.length}`);
assert_array_equals(matches, ['one'], `Unexpected name "a" values: ${matches}`);
}, 'getAll() multiples');
/* eslint-enable */

Expand Down