Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix v8 local handling in node_url.cc #11064

Closed
wants to merge 1 commit into from
Closed

src: fix v8 local handling in node_url.cc #11064

wants to merge 1 commit into from

Commits on Jan 29, 2017

  1. src: fix v8 local handling in node_url.cc 

    Calling `.As<Object>()` on a non-object aborts in debug mode,
but `node_url.cc` relied on it. Address that by using `Local<Value>`
until it has been confirmed that the handle actually is an object.
    @addaleax
    addaleax committed Jan 29, 2017
    Configuration menu
    Copy the full SHA
    c02f8ec View commit details
    Browse the repository at this point in the history