Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v7.x-staging update proposal #10886

Closed
wants to merge 155 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
155 commits
Select commit Hold shift + click to select a range
f127e0c
lib,src: support values > 4GB in heap statistics
bnoordhuis Dec 8, 2016
d05ddc3
doc: modernize child_process example code
vsemozhetbyt Dec 3, 2016
455c442
test: refactor test-https-truncate
Trott Dec 11, 2016
20443d9
test: reduce unmanaged parallelism in domain test
joyeecheung Dec 19, 2016
b8720a0
test: refactor the code in test-fs-watch.js
sivaprs Dec 21, 2016
1262f70
async_wrap: close the destroy_ids_idle_handle_
reshnm Dec 21, 2016
6e3daf4
inspector: remove unused uv_async_t
Dec 21, 2016
b7cf821
doc: clarify information about ABI version
Trott Dec 23, 2016
8c914ca
test, win: fix up symlink tests
digitalinfinity Dec 27, 2016
f3a466a
test: increase usage of assert.ifError()
cjihrig Dec 30, 2016
10abc52
test: use const for all require() calls
cjihrig Dec 30, 2016
59b66ea
test: refactor test-stream2-readable-wrap.js
DavidGoussev Dec 31, 2016
264c935
test: refactor test-timer-close
BethGriggs Dec 29, 2016
e0dce5d
test: improve the code in test-fs-read-stream
edsadr Jan 3, 2017
240555c
test: refactor several parallel/test-timer tests
BethGriggs Dec 29, 2016
f7777b7
test: fix Coverity warning in inspector test
Dec 28, 2016
a5d1e30
url: TupleOrigin#toString use unicode by default
joyeecheung Dec 31, 2016
86ca2e5
doc: update TheAlphaNerd to MylesBorins
MylesBorins Jan 3, 2017
4edd3c2
assert: update comments
Jan 2, 2017
74740b2
util: avoid out-of-bounds arguments index access
not-an-aardvark Jan 2, 2017
76e9fe3
benchmark: move punycode benchmark out of net
mscdex Dec 25, 2016
91c59a6
benchmark: improve readability of net benchmarks
mscdex Dec 25, 2016
0466b59
benchmark: keep decimals in results
mscdex Jan 1, 2017
053fbb2
events: improve removeListener() performance
mscdex Jan 2, 2017
a13b1bc
stream: avoid additional validation for Buffers
mscdex Jan 2, 2017
9f3a43a
test: refactor test-beforeexit-event-exit.js
cjihrig Jan 2, 2017
ec702b8
test: improve test-fs-null-bytes
edsadr Dec 30, 2016
7e28c9f
test: fix process.title expectation
thefourtheye Jan 3, 2017
8923b2f
test: mark test-tty-wrap as flaky for AIX
mhdawson Jan 4, 2017
91e96ab
events: avoid emit() eager deopt
vhf Jan 2, 2017
712d305
benchmark: fix typo "categoty" -> "category"
vhf Jan 2, 2017
aa48bbf
test: refactor beforeExit tests
Trott Jan 3, 2017
38396b3
doc: mention cc-ing nodejs/python team for reviews
addaleax Jan 5, 2017
7c77852
url: change null password handling
jasnell Jan 4, 2017
0646366
url: do not decode arbitrary %2e sequences in paths
jasnell Jan 4, 2017
3bd16b0
meta: decharter the http working group
jasnell Jan 4, 2017
ef4c9ce
test: refactor test-stream-transform-object
Trott Jan 3, 2017
649af4c
test: improve test-fs-access
edsadr Jan 3, 2017
2b5e531
test: check error and cleanups in test-fs-read-buffer
addaleax Jan 4, 2017
9721ddf
doc: new TLSSocket has no secure context options
sam-github Dec 30, 2016
be1385b
test: refactor the code in test-util-debug.js
sivaprs Dec 30, 2016
1aa359e
doc: killSignal option accepts integer values
thefourtheye Dec 23, 2016
ac82dbc
http: eliminate capture of ClientRequest in Agent
evantorrie Dec 5, 2016
7032f81
test: improve test-event-emitter-modify-in-emit
edsadr Jan 6, 2017
9e4d439
test: s/assert.notEqual()/assert.notStrictEqual()/
cjihrig Dec 30, 2016
e9fd084
src: reduce test_inspector_socket_server output
danbev Dec 28, 2016
07b0359
deps: add test for v8 bug in toUpper('ç')
srl295 Nov 28, 2016
a6c4a2e
benchmark,lib,test: adjust for linting
Trott Jan 1, 2017
fa0fdaa
tools: update ESLint to current version
Trott Jan 1, 2017
ac61513
tools: remove custom align-function-arguments rule
Trott Jan 1, 2017
4ea3308
tools: remove no-useless-regex-char-class-escape
Trott Jan 1, 2017
21a929e
test: provide duration/interval to timers
Trott Nov 4, 2016
8501a75
tools: add lint rule to enforce timer arguments
Trott Nov 4, 2016
4990feb
test: refactor test-fs-utimes
jun-oka Oct 26, 2016
26e6233
test: improve test-fs-readfile-zero-byte-liar
edsadr Jan 2, 2017
8665afc
test: improve test-http-chunked-304
edsadr Jan 7, 2017
a7e57d6
test: improve test-fs-write-file-sync
edsadr Jan 7, 2017
752db2a
test: improve code in test-https-strict
edsadr Jan 6, 2017
958319e
url: allow use of URL with http.request and https.request
jasnell Jan 5, 2017
5162337
test: allow testing uid and gid separately
cjihrig Jan 5, 2017
e83d626
test: refactor the code in test-child-process-spawn-loop.js
sivaprs Jan 4, 2017
37bdf59
test: improve zlib-from-gzip-with-trailing-garbage
lfkwtz Jan 7, 2017
9a228d8
test,cluster: add test-cluster-worker-deprecated
Trott Jan 7, 2017
b7ad52c
http: define all used properties in constructors
vitkarpov Oct 16, 2016
d930716
test: refactor test-watch-file.js
sivaprs Jan 7, 2017
eff0ef2
doc: document use of Refs: for references
gibfahn Jan 6, 2017
172c19f
doc: update BUILDING.md
lukaszgasior Jan 6, 2017
34fe56a
test: improve the code in test-process-hrtime
edsadr Jan 8, 2017
19e1220
doc: specify sorted requires in tests
sam-github Jan 9, 2017
4019398
test: improve test-crypto-rsa-dsa
edsadr Jan 9, 2017
71ac1c9
test: refactor test-doctool-html.js
hiroppy Jan 8, 2017
6a6e9f1
test: fix misplaced ) in http response statuscode test
nfriedly Jan 8, 2017
6eb78e4
test: validate 'expected' argument to mustCall()
nfriedly Oct 11, 2016
2e64542
doc: correct vcbuild options for windows testing
jboarman Dec 4, 2016
99326a9
doc: update LTS info for current releases
evanlucas Jan 10, 2017
10a978f
lib: refactor crypto cipher/hash/curve getters
Trott Jan 8, 2017
8b50ba4
test: refactor the code of test-keep-alive.js
sivaprs Jan 8, 2017
19806da
doc: "s/git apply/git am -3" in V8 guide
MylesBorins Jan 6, 2017
f9d797a
test: refactor test-crypto-padding-aes256
radelmann Jan 5, 2017
a09cb27
doc: fix missing negation in stream.md
jrieken Jan 9, 2017
a578ecf
doc: add test naming information to guide
Trott Jan 3, 2017
f4e4a43
test: refactor cluster-preload.js
hiroppy Jan 9, 2017
6add91d
https: Use secureProtocol in Agent#getName
papandreou Nov 2, 2016
14dd85a
test: use eslint to fix var->const/let
gibfahn Jan 8, 2017
5159f6c
assert, tools: enforce strict (not)equal in eslint
gibfahn Jan 8, 2017
0700468
doc: handle backpressure when write() return false
mcollina Jan 5, 2017
5576f8a
doc: sort require statements in tests
sam-github Jan 4, 2017
23f85ab
doc: mention cc-ing nodejs/url team for reviews
addaleax Jan 6, 2017
5e019ca
test: add test for noAssert option in buf.read*()
larissayvette Jan 5, 2017
0a548dc
doc: fix misleading language in vm docs
aqrln Jan 9, 2017
beedd45
doc: edit writing-tests.md
Trott Jan 3, 2017
dd71bf8
src: enable writev for pipe handles on Unix
aqrln Jan 7, 2017
2199033
test: move resource intensive test to sequential
Trott Jan 11, 2017
3ad4a7b
deps: upgrade libuv to 1.10.2
cjihrig Jan 9, 2017
c5ee4ba
benchmark: don't lint autogenerated modules
mscdex Jan 12, 2017
3d7d422
doc: update writable.write return value
binki Jan 3, 2017
2be1fdc
test: move common tls connect setup into fixtures
sam-github Dec 17, 2016
b77b1bb
test: check tls server verification with addCACert
sam-github Dec 20, 2016
243944e
doc: use correct tls certificate property name
sam-github Dec 20, 2016
5fc722b
test: tls cert chain completion scenarios
sam-github Dec 20, 2016
f119220
doc,test: tls .ca option supports multi-PEM files
sam-github Dec 21, 2016
9eb6d6b
eslint: remove dangling eslint symlink
sam-github Jan 12, 2017
f7f2bfc
test: fix linting for test-tls-add-ca-cert.js
sam-github Jan 12, 2017
76cd2b9
test: use realpath for NODE_TEST_DIR in common.js
gibfahn Jan 10, 2017
c4d3625
test: fix temp-dir option in tools/test.py
gibfahn Jan 10, 2017
b987cae
readline: refactor construct Interface
JacksonTian Jan 18, 2016
5ef5147
test: improve tests in pummel/test-exec
chasestarr Jan 12, 2017
a38db9c
test: no unused args test-fs-watch-file.js
istinson Jan 12, 2017
3797401
doc: remove duplicate properties bullet in readme
trendsetter37 Jan 11, 2017
853fd7a
lib: refactor bootstrap_node.js regular expression
Trott Jan 12, 2017
02fa0b3
test: check error msg test-writeint.js
liirene1 Jan 12, 2017
7d45581
http: optimize short path validation
mscdex Jan 6, 2017
072e53b
http: avoid duplicate isArray()
mscdex Jan 6, 2017
1d9c89a
http: misc ClientRequest cleanup
mscdex Jan 6, 2017
43ffc9a
benchmark: add ClientRequest creation benchmark
mscdex Jan 6, 2017
5713e74
test: add http.ClientRequest defaults test
mscdex Jan 6, 2017
a8dbdae
benchmark: use "confidence" in output of compare.R
joyeecheung Jan 11, 2017
d1edb2a
fs: ensure readFile[Sync] reads from the beginning
seishun Jan 14, 2017
f3330d2
benchmark: improve WHATWG URL benchmarks
joyeecheung Jan 10, 2017
53683e0
util: improve readability of normalizeEncoding
joyeecheung Dec 24, 2016
ef27753
test,repl: add coverage for repl .clear+useGlobal
Trott Jan 12, 2017
fea95d7
benchmark: cleanup child_process IPC benchmark
ypresto Dec 31, 2016
b831d9a
child_process: optimize IPC for large data
ypresto Dec 31, 2016
ddb1358
doc: fix broken internal link in process.md
addaleax Jan 16, 2017
c9f99e2
test: skip test-icu-transcode if Intl is not present
watilde Jan 9, 2017
4986ab0
test: add http_incoming's matchKnownFields test
hiroppy Jan 14, 2017
e4b58a5
test: add test case to test-http-response-statuscode.js
hiroppy Jan 14, 2017
05652b0
test: delete duplicate test of noAssert in readUInt*
larissayvette Jan 13, 2017
94450d3
test,util: remove lint workarounds
Trott Jan 13, 2017
393dd5f
test: improve test-fs-write-stream-throw-type
edsadr Jan 13, 2017
390eb84
test: refactor test-cli-eval.js
StarryShark Jan 12, 2017
3735682
doc: clarify memory sharing behavior of buffer ctor
zbjornson Jan 13, 2017
797e1d9
test: increase test-crypto.js strictness
Trott Jan 13, 2017
0df3b4b
test: improve the code in test-process-cpuUsage
edsadr Jan 12, 2017
c98789a
crypto,tls: fix mutability of return values
Trott Jan 13, 2017
4f400a0
test: improve code in test-domain-multi
edsadr Jan 15, 2017
e8ee2af
build: don't squash signal handlers with --shared
Dec 30, 2016
675a292
test: improve code in test-console-instance
edsadr Jan 17, 2017
d24dc56
test: improving coverage for dgram
hiroppy Jan 13, 2017
33e7efb
lib: remove unnecessary parameter for assertCrypto()
JacksonTian Jan 16, 2017
a1601cc
doc: add missing `added:` tag for `zlib.constants`
addaleax Jan 13, 2017
c6e8129
doc: fixup `added` tags in cli.md
addaleax Jan 13, 2017
ff70a55
build: move source files from headers section
danbev Jan 17, 2017
6bc3ce4
doc: remove duplicate PR link from changelog
addaleax Jan 13, 2017
86cb2f5
doc: fix markdown escaping in CHANGELOG_V7.md
addaleax Jan 13, 2017
4aa07cb
doc: add links for zlib convenience methods
addaleax Jan 16, 2017
ce443a6
test: tests for _readableStream.awaitDrain
shmuga Jan 17, 2017
66df57c
fs: remove unused parameter for encodeRealpathResult
JacksonTian Jan 18, 2017
54d52aa
test: improving coverage of dns-lookup
hiroppy Jan 17, 2017
ed2f461
test: add http-common's test
hiroppy Jan 16, 2017
714e04b
doc: HTTP response getHeader doc fix
fhalde Jan 15, 2017
b1e2dc7
benchmark: add benchmark for vm.runIn*()
Trott Jan 15, 2017
cdae2f6
vm: improve performance of vm.runIn*()
Trott Jan 15, 2017
788ae24
doc: clarifying variables in fs.write()
jalafel Nov 24, 2016
d6af213
doc: add edsadr to collaborators
edsadr Jan 18, 2017
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
doc: modernize child_process example code
1. equal => strictEqual.
2. let => const for the variable that is not reassigned.
3. fix spaces.
4. stringify erroneous raw buffer outputs.
5. fix a typo.

PR-URL: #10102
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
vsemozhetbyt authored and italoacasas committed Jan 19, 2017
commit d05ddc3da9363aba6445fcb997178a0196e47c51
34 changes: 17 additions & 17 deletions doc/api/child_process.md
Original file line number Diff line number Diff line change
@@ -91,11 +91,11 @@ const spawn = require('child_process').spawn;
const bat = spawn('cmd.exe', ['/c', 'my.bat']);

bat.stdout.on('data', (data) => {
console.log(data);
console.log(data.toString());
});

bat.stderr.on('data', (data) => {
console.log(data);
console.log(data.toString());
});

bat.on('exit', (code) => {
@@ -113,7 +113,7 @@ exec('my.bat', (err, stdout, stderr) => {
});

// Script with spaces in the filename:
const bat = spawn('"my script.cmd"', ['a', 'b'], { shell:true });
const bat = spawn('"my script.cmd"', ['a', 'b'], { shell: true });
// or:
exec('"my script.cmd" a b', (err, stdout, stderr) => {
// ...
@@ -391,7 +391,7 @@ ps.on('close', (code) => {
});

grep.stdout.on('data', (data) => {
console.log(`${data}`);
console.log(data.toString());
});

grep.stderr.on('data', (data) => {
@@ -475,8 +475,8 @@ const out = fs.openSync('./out.log', 'a');
const err = fs.openSync('./out.log', 'a');

const child = spawn('prg', [], {
detached: true,
stdio: [ 'ignore', out, err ]
detached: true,
stdio: [ 'ignore', out, err ]
});

child.unref();
@@ -876,7 +876,7 @@ as in this example:
'use strict';
const spawn = require('child_process').spawn;

let child = spawn('sh', ['-c',
const child = spawn('sh', ['-c',
`node -e "setInterval(() => {
console.log(process.pid, 'is alive')
}, 500);"`
@@ -1123,21 +1123,21 @@ const fs = require('fs');
const child_process = require('child_process');

const child = child_process.spawn('ls', {
stdio: [
0, // Use parents stdin for child
'pipe', // Pipe child's stdout to parent
fs.openSync('err.out', 'w') // Direct child's stderr to a file
]
stdio: [
0, // Use parent's stdin for child
'pipe', // Pipe child's stdout to parent
fs.openSync('err.out', 'w') // Direct child's stderr to a file
]
});

assert.equal(child.stdio[0], null);
assert.equal(child.stdio[0], child.stdin);
assert.strictEqual(child.stdio[0], null);
assert.strictEqual(child.stdio[0], child.stdin);

assert(child.stdout);
assert.equal(child.stdio[1], child.stdout);
assert.strictEqual(child.stdio[1], child.stdout);

assert.equal(child.stdio[2], null);
assert.equal(child.stdio[2], child.stderr);
assert.strictEqual(child.stdio[2], null);
assert.strictEqual(child.stdio[2], child.stderr);
```

### child.stdout