Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: don't bundle deps/zlib if --shared-zlib set #10657

Merged
merged 1 commit into from
Jan 29, 2017
Merged

build: don't bundle deps/zlib if --shared-zlib set #10657

merged 1 commit into from
Jan 29, 2017

Commits on Jan 29, 2017

  1. build: don't build deps/zlib if --shared-zlib set 

    Even if the --shared-zlib flag was used, the bundled deps/zlib was still
being compiled into the binary as it was required by the C++ test suite.

PR-URL: nodejs#10657
Fixes: nodejs#10649
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    @gibfahn
    gibfahn committed Jan 29, 2017
    Configuration menu
    Copy the full SHA
    ae21a51 View commit details
    Browse the repository at this point in the history