test: allow testing uid and gid separately #10647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
approved these changes
Jan 5, 2017
targos
approved these changes
Jan 5, 2017
mscdex
added
the
child_process
This commit lets the uid and gid options of spawn() to be tested independently of one another based on the user's uid and gid. Fixes: nodejs#10646 PR-URL: nodejs#10647 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 18, 2017
This commit lets the uid and gid options of spawn() to be tested independently of one another based on the user's uid and gid. Fixes: nodejs#10646 PR-URL: nodejs#10647 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 23, 2017
This commit lets the uid and gid options of spawn() to be tested independently of one another based on the user's uid and gid. Fixes: nodejs#10646 PR-URL: nodejs#10647 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 25, 2017
This commit lets the uid and gid options of spawn() to be tested independently of one another based on the user's uid and gid. Fixes: nodejs#10646 PR-URL: nodejs#10647 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 27, 2017
This commit lets the uid and gid options of spawn() to be tested independently of one another based on the user's uid and gid. Fixes: nodejs#10646 PR-URL: nodejs#10647 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit lets the
uidandgidoptions ofspawn()to be tested independently of one another based on the user's uid and gid.Fixes: #10646
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test