Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test revisions #10551

Closed
wants to merge 4 commits into from
Closed

Test revisions #10551

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a26d602
test: remove process.on('exit') with callback wrapper common.mustCall
DavidGoussev Dec 31, 2016
fd8fa5b
test: remove process.on('exit') with callback wrapper common.mustCall
DavidGoussev Dec 31, 2016
15a48bc
test: implement callback wrapper common.mustCall
DavidGoussev Dec 31, 2016
b550a8c
test: refactor test-stream2-readable-wrap.js
DavidGoussev Dec 31, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: remove process.on('exit') with callback wrapper common.mustCall
  • Loading branch information
@DavidGoussev
DavidGoussev committed Dec 31, 2016
commit fd8fa5b1bdf9b2f20701a2b7c482e127b6972717
1 change: 0 additions & 1 deletion test/parallel/test-stream2-readable-wrap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
'use strict';
require('../common');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

common is undefined because this line has not been changed to const common = require('../common'); So again, there's no way this test can actually run as is.

const assert = require('assert');

const Readable = require('_stream_readable');
const Writable = require('_stream_writable');
const EE = require('events').EventEmitter;
Expand Down