Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix flaky test-dgram-exclusive-implicit-bind #10212

Closed
wants to merge 3 commits into from
Closed

test: fix flaky test-dgram-exclusive-implicit-bind #10212

wants to merge 3 commits into from

Commits on Dec 10, 2016

  1. test: fix flaky test-dgram-exclusive-implicit-bind 

    test-dgram-exclusive-implicit-bind is written assuming that dgram
messages are received with 100% reliability. While missing a dgram
message sent to localhost is rare, we do see it as evidenced by CI
failures from time to time.

The test has been rewritten to send dgram messages over and over until
the test requirements have been met.

Additional incidental refactoring includes:

* var -> const
* use of common.mustCall() instead of exit listener + boolean
    @Trott
    Trott committed Dec 10, 2016
    Configuration menu
    Copy the full SHA
    151d2ac View commit details
    Browse the repository at this point in the history

  2. squash: use setInterval instead of chaining setTimeouts

    @Trott
    Trott committed Dec 10, 2016
    Configuration menu
    Copy the full SHA
    909e78e View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2016

  1. squash: clearTimeout() -> clearInterval()

    @Trott
    Trott committed Dec 11, 2016
    Configuration menu
    Copy the full SHA
    e346f84 View commit details
    Browse the repository at this point in the history