[async_wrap] backport of gc abort on destroy() fix on v4.x #10097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The constructor and destructor shouldn't have been placed in the -inl.h file from the beginning. Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
This is how it's done everywhere else in core. Make it follow suit. Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Calling JS during GC is a no-no. So intead create a queue of all ids that need to have their destroy() callback called and call them later. Removed checking destroy() in test-async-wrap-uid because destroy() can be called after the 'exit' callback. Missing a reliable test to reproduce the issue that caused the FATAL_ERROR. Fixes: nodejs#8216 Fixes: nodejs#9465 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
trevnorris
added
async_wrap
c++
nodejs-github-bot
added
c++
2 tasks
mscdex
changed the title
bnoordhuis
approved these changes
Dec 3, 2016
| Environment* env = Environment::from_destroy_ids_idle_handle(handle); | ||
| // None of the V8 calls done outside the HandleScope leak a handle. If this | ||
| // changes in the future then the SealHandleScope wrapping the uv_run() | ||
| // will catch this can cause the process to abort. |
There was a problem hiding this comment.
Isn't this comment outdated? There's a HandleScope right below it! :-)
There was a problem hiding this comment.
heh. seems to have snuck into patches for other versions. I'll remove it here, and remove it in the other branches in an upcoming patch.
|
landed in c0c5608...60883de |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
async_wrap
Description of change
This is a backport of 517e3a6, cf5f4b8 and b49b496 to v4.x
There have been no reports yet of abort on v4.x. So I believe this one can run the usual LTS release path before landing.
CI: https://ci.nodejs.org/job/node-test-commit/6341/