Build failure on Solaris 10 with Node v7 #9856
Copy link
Copy link
Closed
Labels
libuvIssues and PRs related to the libuv dependency or the uv binding.Issues and PRs related to the libuv dependency or the uv binding.smartosIssues and PRs related to the SmartOS platform.Issues and PRs related to the SmartOS platform.
Description
Activity
libuv is a dependency managed outside this repository. Can you move this issue to the libuv repository, possibly in the form of a pull request?
- addedlibuvIssues and PRs related to the libuv dependency or the uv binding.Issues and PRs related to the libuv dependency or the uv binding.
on Nov 30, 2016 - addedsmartosIssues and PRs related to the SmartOS platform.Issues and PRs related to the SmartOS platform.
on Nov 30, 2016 Closing, as this belongs in libuv.
- added a commit that references this issue
on Dec 1, 2016 - added a commit that references this issue
on Jan 18, 2017 - added 2 commits that reference this issue
on Feb 13, 2017 - added 3 commits that reference this issue
on May 18, 2017 - added a commit that references this issue
on Jul 19, 2017
Metadata
Metadata
Assignees
Labels
libuvIssues and PRs related to the libuv dependency or the uv binding.Issues and PRs related to the libuv dependency or the uv binding.smartosIssues and PRs related to the SmartOS platform.Issues and PRs related to the SmartOS platform.
Node v7 (tested v7.2.0) fails to build on Solaris 10.
The problem is in deps/uv/src/unix/sunos.c, where the function uv__set_phys_addr needs to be guarded with SUNOS_NO_IFADDRS. (It's only called from uv_interface_addresses,in code guarded by SUNOS_NO_IFADDRS, so the whole function can be guarded.) See attached patch.
node-v7-sunos-patch.txt