-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools/test.py should be able to get a full path to a test to manually run it #9684
Comments
Personally I'm fine with that as long as the current syntax (including wildcards like |
I was imagining it could likely be a regex/replace for Example implemented with sed $ echo "test/parallel/test-cluster-worker-init.js" | sed 's+test/++; s/.js//'
parallel/test-cluster-worker-init |
This works https://github.com/nodejs/node/compare/master...reconbot:testpy-paths?expand=1 PR worthy? |
@reconbot It works, so I guess there’s nothing speaking against opening a PR and seeing where it goes? (You’ll want to add a |
I found the handy contributors guide link when opening the PR. I think I got it right |
I'm with @bnoordhuis; would accept such a PR. |
@addaleax thanks for the subsection btw, it wasn't clear to me what that should be |
Allow test.py to run tests with a 'tests/' prefix or a '.js' postfix Fixes: nodejs#9684
Allow test.py to run tests with a 'tests/' prefix or a '.js' postfix PR-URL: #9694 Fixes: #9684 Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Allow test.py to run tests with a 'tests/' prefix or a '.js' postfix PR-URL: #9694 Fixes: #9684 Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Allow test.py to run tests with a 'tests/' prefix or a '.js' postfix PR-URL: #9694 Fixes: #9684 Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Currently if you want to manually run a test you have to remove
test/
from the beginning of the path and not include the js prefix.For example the following commands will not work
but the following will
I find this counter intuitive and would like the ability to pass the full path to a test
/cc @nodejs/build @jbergstroem do you oppose to this being done?
The text was updated successfully, but these errors were encountered: