doc: explain why we don't use the GitHub merge button

[Trott]

I get asked why we can't use the GitHub merge button at onboardings from time to time and I never know what issues with it are real and what I merely imagine.

onboarding.md currently says:

• Please never use GitHub's green "Merge Pull Request" button.
  • If you do, please force-push removing the merge.

And that's it. One or two sentences explaining the deal-breaker incompatibilities with our workflow would be great. @cjihrig? Someone else?

[MylesBorins]

the latest rebase feature changes the author

the old rebase and merge feature adds meta data to the commit title

the original merge method adds a merge commit

On Sun, Oct 2, 2016, 1:53 AM Rich Trott notifications@github.com wrote:

I get asked this at onboardings from time to time and I never know what
issues with it are real and what's just in my mind.

onboarding.md currently says:

• Please never use GitHub's green "Merge Pull Request" button.
  • If you do, please force-push removing the merge.

And that's it. One or two sentences explaining the deal-breaker
incompatibilities with our workflow would be great. @cjihrig
https://github.com/cjihrig? Someone else?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#8893, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAecVzDskV5JaHh9uSbBEZ2RUDqgIIDyks5qv0a7gaJpZM4KL8Sz
.

[not-an-aardvark]

the old rebase and merge feature adds meta data to the commit title

Squash/merge does that by default, but isn't it possible to modify the commit message while merging?

[MylesBorins]

@not-an-aardvark I've personally experienced it adding the meta data without an obvious way to avoid it. At the very least it is error prone enough that I do not believe the pain is worth the benefit

[evanlucas]

the latest rebase feature changes the author

yep, I dealt with that last week while cutting v6.7.0.

I would say that @thealphanerd's comment (#8893 (comment)) describes it pretty well.

[Fishrock123]

Yeah, what @thealphanerd said.

[Fishrock123]

(All of which make viewing commits / tooling / attribution / etc more difficult.)

[fhinkel]

Have we documented anywhere why we add Reviewed-By? I'm not sure what it's good for.

[bnoordhuis]

It's like git blame for reviewers.

[addaleax]

Have we documented anywhere why we add Reviewed-By? I'm not sure what it's good for.

It also gives a list of people to @mention / contact when something goes wrong, and doesn’t require the assumption that Github lasts forever for that ;)

[sonalbhadani496]

We generally don't use Github merge button when we don't want the changes in our branch to be merged with the upstream branch ; for this we can also close the pull request without merging.