Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: confusing comment #8856

Closed
mscdex opened this issue Sep 30, 2016 · 0 comments
Closed

stream: confusing comment #8856

mscdex opened this issue Sep 30, 2016 · 0 comments
Labels
good first issue Issues that are suitable for first-time contributors. stream Issues and PRs related to the stream subsystem.

Comments

@mscdex
Copy link
Contributor

mscdex commented Sep 30, 2016 •
edited
Loading

  • Version: all
  • Platform: n/a
  • Subsystem: stream

In e26622b, a comment was incorrectly moved from the code it was describing.

AFAICT the comment just needs to be moved back so that it's referring to the correct block of code again.
@mscdex mscdex added stream Issues and PRs related to the stream subsystem. good first issue Issues that are suitable for first-time contributors. labels Sep 30, 2016
@madhavgharmalkar madhavgharmalkar mentioned this issue Sep 30, 2016
Closed
2 tasks
jasnell pushed a commit that referenced this issue Oct 6, 2016
@madhavgharmalkar @jasnell
src: fixes misplaced comment
ba153e6 
In e26622b, a comment was incorrectly moved from the code
it was describing.

Fixes: #8856
PR-URL: #8860
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Fishrock123 pushed a commit that referenced this issue Oct 11, 2016
@madhavgharmalkar @Fishrock123
src: fixes misplaced comment
324c8b5 
In e26622b, a comment was incorrectly moved from the code
it was describing.

Fixes: #8856
PR-URL: #8860
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Issues that are suitable for first-time contributors. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

stream: fixed misplaced comment
1 participant
@mscdex