Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream, test: add test for _readableState.readingMore #8685

Closed
mcollina opened this issue Sep 21, 2016 · 3 comments
Closed

stream, test: add test for _readableState.readingMore #8685

mcollina opened this issue Sep 21, 2016 · 3 comments
Labels
good first issue Issues that are suitable for first-time contributors. stream Issues and PRs related to the stream subsystem. test Issues and PRs related to the tests.

Comments

@mcollina
Copy link
Member

mcollina commented Sep 21, 2016 •
edited
Loading

Part of #8644.

stream._readableState.readingMore

node/lib/_stream_readable.js

Lines 91 to 92 in 774146d

// if true, a maybeReadMore has been scheduled
this.readingMore = false;

cc @Fishrock123 @nodejs/streams
@mcollina mcollina added stream Issues and PRs related to the stream subsystem. test Issues and PRs related to the tests. good first issue Issues that are suitable for first-time contributors. labels Sep 21, 2016
@mansimarkaur
Copy link

I'd like to work on this as my first contribution.

@chmln chmln mentioned this issue Dec 1, 2016
Closed
4 tasks
@chmln
Copy link
Contributor

chmln commented Dec 1, 2016

@mansimarkaur OK if I contribute?

@mansimarkaur
Copy link

@chmln sure.

italoacasas pushed a commit that referenced this issue Dec 11, 2016
@chmln @italoacasas
test: stream readableState readingMore state
8621ccc 
PR-URL: #9868
Refs: #8685
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Fishrock123 pushed a commit that referenced this issue Dec 13, 2016
@chmln @Fishrock123
test: stream readableState readingMore state
6780c0e 
PR-URL: #9868
Refs: #8685
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
MylesBorins pushed a commit that referenced this issue Jan 23, 2017
@chmln @MylesBorins
test: stream readableState readingMore state
8f4c29b 
PR-URL: #9868
Refs: #8685
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
MylesBorins pushed a commit that referenced this issue Jan 23, 2017
@chmln @MylesBorins
test: stream readableState readingMore state
16a74f4 
PR-URL: #9868
Refs: #8685
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
MylesBorins pushed a commit that referenced this issue Jan 24, 2017
@chmln @MylesBorins
test: stream readableState readingMore state
8be5e04 
PR-URL: #9868
Refs: #8685
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
MylesBorins pushed a commit that referenced this issue Jan 24, 2017
@chmln @MylesBorins
test: stream readableState readingMore state
23677ba 
PR-URL: #9868
Refs: #8685
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
MylesBorins pushed a commit that referenced this issue Jan 31, 2017
@chmln @MylesBorins
test: stream readableState readingMore state
25d6eed 
PR-URL: #9868
Refs: #8685
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
MylesBorins pushed a commit that referenced this issue Feb 1, 2017
@chmln @MylesBorins
test: stream readableState readingMore state
544920f 
PR-URL: #9868
Refs: #8685
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Issues that are suitable for first-time contributors. stream Issues and PRs related to the stream subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mcollina @italoacasas @chmln @mansimarkaur