Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test failures on macOS Sierra 10.12 (GM) with Xcode 8.0 (GM) #8498

Closed
dnalborczyk opened this issue Sep 12, 2016 · 7 comments
Closed

Test failures on macOS Sierra 10.12 (GM) with Xcode 8.0 (GM) #8498

dnalborczyk opened this issue Sep 12, 2016 · 7 comments
Labels
confirmed-bug Issues with confirmed bugs. inspector Issues and PRs related to the V8 inspector protocol test Issues and PRs related to the tests.

Comments

@dnalborczyk
Copy link
Contributor

dnalborczyk commented Sep 12, 2016 •
edited
Loading

  • Version: master (latest)
  • Platform: macOS Sierra 10.12 (GM), Xcode 8.0 (GM)
  • Subsystem: -

I don't know who is responsible for the failures, macOS, Xcode or a combination.

./configure
make test

[==========] Running 22 tests from 2 test cases.
[----------] Global test environment set-up.
[----------] 4 tests from UtilTest
[ RUN      ] UtilTest.ListHead
[       OK ] UtilTest.ListHead (0 ms)
[ RUN      ] UtilTest.StringEqualNoCase
[       OK ] UtilTest.StringEqualNoCase (0 ms)
[ RUN      ] UtilTest.StringEqualNoCaseN
[       OK ] UtilTest.StringEqualNoCaseN (0 ms)
[ RUN      ] UtilTest.ToLower
[       OK ] UtilTest.ToLower (0 ms)
[----------] 4 tests from UtilTest (0 ms total)

[----------] 18 tests from InspectorSocketTest
[ RUN      ] InspectorSocketTest.ReadsAndWritesInspectorMessage
[       OK ] InspectorSocketTest.ReadsAndWritesInspectorMessage (0 ms)
[ RUN      ] InspectorSocketTest.BufferEdgeCases
[       OK ] InspectorSocketTest.BufferEdgeCases (1 ms)
[ RUN      ] InspectorSocketTest.AcceptsRequestInSeveralWrites
[       OK ] InspectorSocketTest.AcceptsRequestInSeveralWrites (0 ms)
[ RUN      ] InspectorSocketTest.ExtraTextBeforeRequest
../test/cctest/test_inspector_socket.cc:485: Failure
Value of: 0
Expected: uv_is_active(reinterpret_cast<uv_handle_t*>(&socket))
Which is: 1
[  FAILED  ] InspectorSocketTest.ExtraTextBeforeRequest (0 ms)
[ RUN      ] InspectorSocketTest.ExtraLettersBeforeRequest
../test/cctest/test_inspector_socket.cc:497: Failure
Value of: 0
Expected: uv_is_active(reinterpret_cast<uv_handle_t*>(&socket))
Which is: 1
[  FAILED  ] InspectorSocketTest.ExtraLettersBeforeRequest (1 ms)
[ RUN      ] InspectorSocketTest.RequestWithoutKey
../test/cctest/test_inspector_socket.cc:512: Failure
Value of: 0
Expected: uv_is_active(reinterpret_cast<uv_handle_t*>(&socket))
Which is: 1
[  FAILED  ] InspectorSocketTest.RequestWithoutKey (0 ms)
[ RUN      ] InspectorSocketTest.KillsConnectionOnProtocolViolation
[       OK ] InspectorSocketTest.KillsConnectionOnProtocolViolation (0 ms)
[ RUN      ] InspectorSocketTest.CanStopReadingFromInspector
[       OK ] InspectorSocketTest.CanStopReadingFromInspector (0 ms)
[ RUN      ] InspectorSocketTest.CloseDoesNotNotifyReadCallback
[       OK ] InspectorSocketTest.CloseDoesNotNotifyReadCallback (1 ms)
[ RUN      ] InspectorSocketTest.CloseWorksWithoutReadEnabled
[       OK ] InspectorSocketTest.CloseWorksWithoutReadEnabled (0 ms)
[ RUN      ] InspectorSocketTest.ReportsHttpGet
[       OK ] InspectorSocketTest.ReportsHttpGet (4 ms)
[ RUN      ] InspectorSocketTest.HandshakeCanBeCanceled
[       OK ] InspectorSocketTest.HandshakeCanBeCanceled (1 ms)
[ RUN      ] InspectorSocketTest.GetThenHandshake
[       OK ] InspectorSocketTest.GetThenHandshake (0 ms)
[ RUN      ] InspectorSocketTest.WriteBeforeHandshake
[       OK ] InspectorSocketTest.WriteBeforeHandshake (0 ms)
[ RUN      ] InspectorSocketTest.CleanupSocketAfterEOF
[       OK ] InspectorSocketTest.CleanupSocketAfterEOF (4 ms)
[ RUN      ] InspectorSocketTest.EOFBeforeHandshake
[       OK ] InspectorSocketTest.EOFBeforeHandshake (1 ms)
[ RUN      ] InspectorSocketTest.Send1Mb
[       OK ] InspectorSocketTest.Send1Mb (15 ms)
[ RUN      ] InspectorSocketTest.ErrorCleansUpTheSocket
[       OK ] InspectorSocketTest.ErrorCleansUpTheSocket (1 ms)
[----------] 18 tests from InspectorSocketTest (29 ms total)

[----------] Global test environment tear-down
[==========] 22 tests from 2 test cases ran. (29 ms total)
[  PASSED  ] 19 tests.
[  FAILED  ] 3 tests, listed below:
[  FAILED  ] InspectorSocketTest.ExtraTextBeforeRequest
[  FAILED  ] InspectorSocketTest.ExtraLettersBeforeRequest
[  FAILED  ] InspectorSocketTest.RequestWithoutKey

 3 FAILED TESTS
make[1]: *** [cctest] Error 1
make: *** [test] Error 2
@bnoordhuis
Copy link
Member

Those are the sames failures as #8034 (comment). For some reason it happens on some systems, but not others.

@bnoordhuis bnoordhuis added test Issues and PRs related to the tests. inspector Issues and PRs related to the V8 inspector protocol labels Sep 12, 2016
@eugeneo
Copy link
Contributor

eugeneo commented Sep 12, 2016

I will take a look. I believe this is a race condition, so far I did not see it on any system I use...

@eugeneo eugeneo mentioned this issue Sep 12, 2016
Closed
3 tasks
@eugeneo
Copy link
Contributor

eugeneo commented Sep 12, 2016

Please try if #8505 fixes this.

@dnalborczyk
Copy link
Contributor Author

dnalborczyk commented Sep 12, 2016 •
edited
Loading

unfortunately same failures, with different output.
the failing test cases also seem to "pause" for a bit while running. not sure if that is intended.

[==========] Running 22 tests from 2 test cases.
[----------] Global test environment set-up.
[----------] 4 tests from UtilTest
[ RUN      ] UtilTest.ListHead
[       OK ] UtilTest.ListHead (0 ms)
[ RUN      ] UtilTest.StringEqualNoCase
[       OK ] UtilTest.StringEqualNoCase (0 ms)
[ RUN      ] UtilTest.StringEqualNoCaseN
[       OK ] UtilTest.StringEqualNoCaseN (0 ms)
[ RUN      ] UtilTest.ToLower
[       OK ] UtilTest.ToLower (0 ms)
[----------] 4 tests from UtilTest (0 ms total)

[----------] 18 tests from InspectorSocketTest
[ RUN      ] InspectorSocketTest.ReadsAndWritesInspectorMessage
[       OK ] InspectorSocketTest.ReadsAndWritesInspectorMessage (1 ms)
[ RUN      ] InspectorSocketTest.BufferEdgeCases
[       OK ] InspectorSocketTest.BufferEdgeCases (1 ms)
[ RUN      ] InspectorSocketTest.AcceptsRequestInSeveralWrites
[       OK ] InspectorSocketTest.AcceptsRequestInSeveralWrites (0 ms)
[ RUN      ] InspectorSocketTest.ExtraTextBeforeRequest
../test/cctest/test_inspector_socket.cc:311: Failure
Value of: (uv_is_active(reinterpret_cast<uv_handle_t*>(&socket)))
  Actual: true
Expected: false
[  FAILED  ] InspectorSocketTest.ExtraTextBeforeRequest (4999 ms)
[ RUN      ] InspectorSocketTest.ExtraLettersBeforeRequest
../test/cctest/test_inspector_socket.cc:311: Failure
Value of: (uv_is_active(reinterpret_cast<uv_handle_t*>(&socket)))
  Actual: true
Expected: false
[  FAILED  ] InspectorSocketTest.ExtraLettersBeforeRequest (5000 ms)
[ RUN      ] InspectorSocketTest.RequestWithoutKey
../test/cctest/test_inspector_socket.cc:311: Failure
Value of: (uv_is_active(reinterpret_cast<uv_handle_t*>(&socket)))
  Actual: true
Expected: false
[  FAILED  ] InspectorSocketTest.RequestWithoutKey (5000 ms)
[ RUN      ] InspectorSocketTest.KillsConnectionOnProtocolViolation
[       OK ] InspectorSocketTest.KillsConnectionOnProtocolViolation (0 ms)
[ RUN      ] InspectorSocketTest.CanStopReadingFromInspector
[       OK ] InspectorSocketTest.CanStopReadingFromInspector (1 ms)
[ RUN      ] InspectorSocketTest.CloseDoesNotNotifyReadCallback
[       OK ] InspectorSocketTest.CloseDoesNotNotifyReadCallback (0 ms)
[ RUN      ] InspectorSocketTest.CloseWorksWithoutReadEnabled
[       OK ] InspectorSocketTest.CloseWorksWithoutReadEnabled (0 ms)
[ RUN      ] InspectorSocketTest.ReportsHttpGet
[       OK ] InspectorSocketTest.ReportsHttpGet (5 ms)
[ RUN      ] InspectorSocketTest.HandshakeCanBeCanceled
[       OK ] InspectorSocketTest.HandshakeCanBeCanceled (0 ms)
[ RUN      ] InspectorSocketTest.GetThenHandshake
[       OK ] InspectorSocketTest.GetThenHandshake (1 ms)
[ RUN      ] InspectorSocketTest.WriteBeforeHandshake
[       OK ] InspectorSocketTest.WriteBeforeHandshake (0 ms)
[ RUN      ] InspectorSocketTest.CleanupSocketAfterEOF
[       OK ] InspectorSocketTest.CleanupSocketAfterEOF (4 ms)
[ RUN      ] InspectorSocketTest.EOFBeforeHandshake
[       OK ] InspectorSocketTest.EOFBeforeHandshake (0 ms)
[ RUN      ] InspectorSocketTest.Send1Mb
[       OK ] InspectorSocketTest.Send1Mb (15 ms)
[ RUN      ] InspectorSocketTest.ErrorCleansUpTheSocket
[       OK ] InspectorSocketTest.ErrorCleansUpTheSocket (0 ms)
[----------] 18 tests from InspectorSocketTest (15027 ms total)

[----------] Global test environment tear-down
[==========] 22 tests from 2 test cases ran. (15027 ms total)
[  PASSED  ] 19 tests.
[  FAILED  ] 3 tests, listed below:
[  FAILED  ] InspectorSocketTest.ExtraTextBeforeRequest
[  FAILED  ] InspectorSocketTest.ExtraLettersBeforeRequest
[  FAILED  ] InspectorSocketTest.RequestWithoutKey

 3 FAILED TESTS
make[1]: *** [cctest] Error 1
make: *** [test] Error 2

@eugeneo
Copy link
Contributor

eugeneo commented Sep 12, 2016

Please try the newer revisions. I just realized there was a coding mistake and socket is actually not a variable but a function from the platform library...

@dnalborczyk
Copy link
Contributor Author

👍 looks good!!

[==========] Running 22 tests from 2 test cases.
[----------] Global test environment set-up.
[----------] 4 tests from UtilTest
[ RUN      ] UtilTest.ListHead
[       OK ] UtilTest.ListHead (0 ms)
[ RUN      ] UtilTest.StringEqualNoCase
[       OK ] UtilTest.StringEqualNoCase (0 ms)
[ RUN      ] UtilTest.StringEqualNoCaseN
[       OK ] UtilTest.StringEqualNoCaseN (0 ms)
[ RUN      ] UtilTest.ToLower
[       OK ] UtilTest.ToLower (0 ms)
[----------] 4 tests from UtilTest (0 ms total)

[----------] 18 tests from InspectorSocketTest
[ RUN      ] InspectorSocketTest.ReadsAndWritesInspectorMessage
[       OK ] InspectorSocketTest.ReadsAndWritesInspectorMessage (1 ms)
[ RUN      ] InspectorSocketTest.BufferEdgeCases
[       OK ] InspectorSocketTest.BufferEdgeCases (0 ms)
[ RUN      ] InspectorSocketTest.AcceptsRequestInSeveralWrites
[       OK ] InspectorSocketTest.AcceptsRequestInSeveralWrites (1 ms)
[ RUN      ] InspectorSocketTest.ExtraTextBeforeRequest
[       OK ] InspectorSocketTest.ExtraTextBeforeRequest (0 ms)
[ RUN      ] InspectorSocketTest.ExtraLettersBeforeRequest
[       OK ] InspectorSocketTest.ExtraLettersBeforeRequest (0 ms)
[ RUN      ] InspectorSocketTest.RequestWithoutKey
[       OK ] InspectorSocketTest.RequestWithoutKey (0 ms)
[ RUN      ] InspectorSocketTest.KillsConnectionOnProtocolViolation
[       OK ] InspectorSocketTest.KillsConnectionOnProtocolViolation (1 ms)
[ RUN      ] InspectorSocketTest.CanStopReadingFromInspector
[       OK ] InspectorSocketTest.CanStopReadingFromInspector (0 ms)
[ RUN      ] InspectorSocketTest.CloseDoesNotNotifyReadCallback
[       OK ] InspectorSocketTest.CloseDoesNotNotifyReadCallback (0 ms)
[ RUN      ] InspectorSocketTest.CloseWorksWithoutReadEnabled
[       OK ] InspectorSocketTest.CloseWorksWithoutReadEnabled (0 ms)
[ RUN      ] InspectorSocketTest.ReportsHttpGet
[       OK ] InspectorSocketTest.ReportsHttpGet (5 ms)
[ RUN      ] InspectorSocketTest.HandshakeCanBeCanceled
[       OK ] InspectorSocketTest.HandshakeCanBeCanceled (0 ms)
[ RUN      ] InspectorSocketTest.GetThenHandshake
[       OK ] InspectorSocketTest.GetThenHandshake (0 ms)
[ RUN      ] InspectorSocketTest.WriteBeforeHandshake
[       OK ] InspectorSocketTest.WriteBeforeHandshake (0 ms)
[ RUN      ] InspectorSocketTest.CleanupSocketAfterEOF
[       OK ] InspectorSocketTest.CleanupSocketAfterEOF (4 ms)
[ RUN      ] InspectorSocketTest.EOFBeforeHandshake
[       OK ] InspectorSocketTest.EOFBeforeHandshake (1 ms)
[ RUN      ] InspectorSocketTest.Send1Mb
[       OK ] InspectorSocketTest.Send1Mb (14 ms)
[ RUN      ] InspectorSocketTest.ErrorCleansUpTheSocket
[       OK ] InspectorSocketTest.ErrorCleansUpTheSocket (0 ms)
[----------] 18 tests from InspectorSocketTest (27 ms total)

[----------] Global test environment tear-down
[==========] 22 tests from 2 test cases ran. (27 ms total)
[  PASSED  ] 22 tests.
/usr/bin/python tools/test.py --mode=release -J \
        addons doctool known_issues message pseudo-tty parallel sequential
[01:16|% 100|+ 1234|-   0]: Done
/Applications/Xcode.app/Contents/Developer/usr/bin/make lint
./node tools/eslint/bin/eslint.js --cache --rulesdir=tools/eslint-rules \
      benchmark lib test tools
Total errors found: 0

@mscdex mscdex mentioned this issue Sep 17, 2016
Closed
@Thylossus
Copy link

Hi,

I would like to add that I'm experiencing the same issue. I forked and cloned the repo just this morning and I am using Windows. So this issue is probably not Mac specific.

Specs:

  • Version: master (latest)
  • Platform: Windows 8.1 (Version 6.3 Build 9600) with Visual Studio 2015
Running main() from gtest_main.cc
[==========] Running 22 tests from 2 test cases.
[----------] Global test environment set-up.
[----------] 4 tests from UtilTest
[ RUN      ] UtilTest.ListHead
[       OK ] UtilTest.ListHead (1 ms)
[ RUN      ] UtilTest.StringEqualNoCase
[       OK ] UtilTest.StringEqualNoCase (0 ms)
[ RUN      ] UtilTest.StringEqualNoCaseN
[       OK ] UtilTest.StringEqualNoCaseN (0 ms)
[ RUN      ] UtilTest.ToLower
[       OK ] UtilTest.ToLower (0 ms)
[----------] 4 tests from UtilTest (2 ms total)

[----------] 18 tests from InspectorSocketTest
[ RUN      ] InspectorSocketTest.ReadsAndWritesInspectorMessage
[       OK ] InspectorSocketTest.ReadsAndWritesInspectorMessage (13 ms)
[ RUN      ] InspectorSocketTest.BufferEdgeCases
[       OK ] InspectorSocketTest.BufferEdgeCases (4 ms)
[ RUN      ] InspectorSocketTest.AcceptsRequestInSeveralWrites
[       OK ] InspectorSocketTest.AcceptsRequestInSeveralWrites (4 ms)
[ RUN      ] InspectorSocketTest.ExtraTextBeforeRequest
test\cctest\test_inspector_socket.cc(505): error: Value of: 0
Expected: uv_is_active(reinterpret_cast<uv_handle_t*>(&socket))
Which is: 1
[  FAILED  ] InspectorSocketTest.ExtraTextBeforeRequest (5 ms)
[ RUN      ] InspectorSocketTest.ExtraLettersBeforeRequest
test\cctest\test_inspector_socket.cc(517): error: Value of: 0
Expected: uv_is_active(reinterpret_cast<uv_handle_t*>(&socket))
Which is: 1
[  FAILED  ] InspectorSocketTest.ExtraLettersBeforeRequest (4 ms)
[ RUN      ] InspectorSocketTest.RequestWithoutKey
test\cctest\test_inspector_socket.cc(532): error: Value of: 0
Expected: uv_is_active(reinterpret_cast<uv_handle_t*>(&socket))
Which is: 1
[  FAILED  ] InspectorSocketTest.RequestWithoutKey (5 ms)
[ RUN      ] InspectorSocketTest.KillsConnectionOnProtocolViolation
[       OK ] InspectorSocketTest.KillsConnectionOnProtocolViolation (5 ms)
[ RUN      ] InspectorSocketTest.CanStopReadingFromInspector
[       OK ] InspectorSocketTest.CanStopReadingFromInspector (5 ms)
[ RUN      ] InspectorSocketTest.CloseDoesNotNotifyReadCallback
[       OK ] InspectorSocketTest.CloseDoesNotNotifyReadCallback (6 ms)
[ RUN      ] InspectorSocketTest.CloseWorksWithoutReadEnabled
[       OK ] InspectorSocketTest.CloseWorksWithoutReadEnabled (6 ms)
[ RUN      ] InspectorSocketTest.ReportsHttpGet
[       OK ] InspectorSocketTest.ReportsHttpGet (25 ms)
[ RUN      ] InspectorSocketTest.HandshakeCanBeCanceled
[       OK ] InspectorSocketTest.HandshakeCanBeCanceled (6 ms)
[ RUN      ] InspectorSocketTest.GetThenHandshake
[       OK ] InspectorSocketTest.GetThenHandshake (6 ms)
[ RUN      ] InspectorSocketTest.WriteBeforeHandshake
[       OK ] InspectorSocketTest.WriteBeforeHandshake (5 ms)
[ RUN      ] InspectorSocketTest.CleanupSocketAfterEOF
[       OK ] InspectorSocketTest.CleanupSocketAfterEOF (23 ms)
[ RUN      ] InspectorSocketTest.EOFBeforeHandshake
[       OK ] InspectorSocketTest.EOFBeforeHandshake (5 ms)
[ RUN      ] InspectorSocketTest.Send1Mb
[       OK ] InspectorSocketTest.Send1Mb (43 ms)
[ RUN      ] InspectorSocketTest.ErrorCleansUpTheSocket
[       OK ] InspectorSocketTest.ErrorCleansUpTheSocket (5 ms)
[----------] 18 tests from InspectorSocketTest (184 ms total)

[----------] Global test environment tear-down
[==========] 22 tests from 2 test cases ran. (188 ms total)
[  PASSED  ] 19 tests.
[  FAILED  ] 3 tests, listed below:
[  FAILED  ] InspectorSocketTest.ExtraTextBeforeRequest
[  FAILED  ] InspectorSocketTest.ExtraLettersBeforeRequest
[  FAILED  ] InspectorSocketTest.RequestWithoutKey

 3 FAILED TESTS

@ChALkeR ChALkeR changed the title Test failures on macOS Sierra 10.2 (GM) with Xcode 8.0 (GM) Test failures on macOS Sierra 10.12 (GM) with Xcode 8.0 (GM) Sep 17, 2016
@jasnell jasnell added the confirmed-bug Issues with confirmed bugs. label Sep 21, 2016
MylesBorins pushed a commit to MylesBorins/node that referenced this issue Sep 28, 2016
inspector: wait for both sides closing
5f057ee 
Removes race condition when test relied on both sides of the socket
to be closed on the same UV event loop iteration.

Fixes: nodejs#8498
PR-URL: nodejs#8505
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-by: Fedor Indutny <fedor@indutny.com>
jasnell pushed a commit that referenced this issue Sep 29, 2016
@jasnell
inspector: wait for both sides closing
df048d1 
Removes race condition when test relied on both sides of the socket
to be closed on the same UV event loop iteration.

Fixes: #8498
PR-URL: #8505
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-by: Fedor Indutny <fedor@indutny.com>
MylesBorins pushed a commit that referenced this issue Sep 30, 2016
inspector: wait for both sides closing
f817875 
Removes race condition when test relied on both sides of the socket
to be closed on the same UV event loop iteration.

Fixes: #8498
PR-URL: #8505
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-by: Fedor Indutny <fedor@indutny.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
confirmed-bug Issues with confirmed bugs. inspector Issues and PRs related to the V8 inspector protocol test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

inspector: wait for both sides closing
5 participants
@bnoordhuis @eugeneo @jasnell @dnalborczyk @Thylossus