AIX: parallel/test-cluster-dgram-1 failuresΒ #8380
Copy link
Copy link
Closed
Labels
clusterIssues and PRs related to the cluster subsystem.Issues and PRs related to the cluster subsystem.dgramIssues and PRs related to UDP and the dgram module.Issues and PRs related to UDP and the dgram module.testIssues and PRs related to Node.js core tests and test infrastructure.Issues and PRs related to Node.js core tests and test infrastructure.
Description
- Version: master
- Platform: AIX
- Subsystem: cluster
This test seems to have started failing recently:
not ok 112 parallel/test-cluster-dgram-1
# Mismatched <anonymous> function calls. Expected 1, actual 0.
# at setupWorker (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/test/parallel/test-cluster-dgram-1.js:69:36)
# at master (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/test/parallel/test-cluster-dgram-1.js:59:7)
# at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/test/parallel/test-cluster-dgram-1.js:18:3)
# at Module._compile (module.js:556:32)
# at Object.Module._extensions..js (module.js:565:10)
# at Module.load (module.js:473:32)
# at tryModuleLoad (module.js:432:12)
# at Function.Module._load (module.js:424:3)
# at Module.runMain (module.js:590:10)
# Mismatched <anonymous> function calls. Expected 1, actual 0.
# at setupWorker (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/test/parallel/test-cluster-dgram-1.js:69:36)
# at master (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/test/parallel/test-cluster-dgram-1.js:59:7)
# at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/test/parallel/test-cluster-dgram-1.js:18:3)
# at Module._compile (module.js:556:32)
# at Object.Module._extensions..js (module.js:565:10)
# at Module.load (module.js:473:32)
# at tryModuleLoad (module.js:432:12)
# at Function.Module._load (module.js:424:3)
# at Module.runMain (module.js:590:10)
# Mismatched <anonymous> function calls. Expected 1, actual 0.
# at setupWorker (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/test/parallel/test-cluster-dgram-1.js:69:36)
# at master (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/test/parallel/test-cluster-dgram-1.js:59:7)
# at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/test/parallel/test-cluster-dgram-1.js:18:3)
# at Module._compile (module.js:556:32)
# at Object.Module._extensions..js (module.js:565:10)
# at Module.load (module.js:473:32)
# at tryModuleLoad (module.js:432:12)
# at Function.Module._load (module.js:424:3)
# at Module.runMain (module.js:590:10)
# Mismatched <anonymous> function calls. Expected 1, actual 0.
# at setupWorker (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/test/parallel/test-cluster-dgram-1.js:69:36)
# at master (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/test/parallel/test-cluster-dgram-1.js:59:7)
# at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/test/parallel/test-cluster-dgram-1.js:18:3)
# at Module._compile (module.js:556:32)
# at Object.Module._extensions..js (module.js:565:10)
# at Module.load (module.js:473:32)
# at tryModuleLoad (module.js:432:12)
# at Function.Module._load (module.js:424:3)
# at Module.runMain (module.js:590:10)
---
duration_ms: 0.833
...
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
clusterIssues and PRs related to the cluster subsystem.Issues and PRs related to the cluster subsystem.dgramIssues and PRs related to UDP and the dgram module.Issues and PRs related to UDP and the dgram module.testIssues and PRs related to Node.js core tests and test infrastructure.Issues and PRs related to Node.js core tests and test infrastructure.
Activity
mhdawson commentedon Sep 2, 2016
May be related to this refactoring: #8261 which landed recently.
mhdawson commentedon Sep 2, 2016
@jasnell. Opened issue to cover and has info printed from last failure.
mhdawson commentedon Sep 2, 2016
Can we either revert the refactor of this specific test case until we can figure out the right way to go ?
test: fix test-cluster-dgram-1 flakiness
santigimeno commentedon Sep 2, 2016
#8383 fixes the issue for me in
FreeBSD.jasnell commentedon Sep 2, 2016
@mhdawson ... can you test if #8383 fixes the issue on AIX. If it does not, then reverting the change for this one test is just fine.
mhdawson commentedon Sep 2, 2016
Ok starting tests now.
mhdawson commentedon Sep 2, 2016
Tested results are in #8383
Net is that is helps but I still see failure 3/150 versus 0 with the old version.
jasnell commentedon Sep 2, 2016
Ok, let's revert this one then. I'll get the PR together for that shortly.
mhdawson commentedon Sep 2, 2016
PR to revert that one test if we decide its the right way to go: https://github.com/nodejs/node/pull/8384/files
mhdawson commentedon Sep 2, 2016
Ok updated fix in #8383 resolves the issues. :)
jasnell commentedon Sep 2, 2016
It looks like the failure here may have been happening before the refactor but just hadn't been caught. Adding the
common.mustCall()added the additional constraint that highlighted the flaky failure. I'd say that's a win ;-) Thanks for looking into it @mhdawsontest: fix test-cluster-dgram-1 flakiness
test: fix test-cluster-dgram-1 flakiness
test: fix test-cluster-dgram-1 flakiness