You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
debugger: bind to random port with --inspect=0 #8080
@azjkjensen this is probably a good place to start. Allowing 0 here seems to make it work for me, but I didn't run the full test suite, and there could be other nuances.
@cjihrig it looks like that change works, I just need to write a test for it and then I'll make a PR. Is a single test usually sufficient for a change like this? This is my first time contributing so such a large project.
Is a single test usually sufficient for a change like this?
Use your judgment, if you can think of more than one relevant situation write more than one test...
Good place to look is at test that already check --inspect or --inspect-brklike test/parallel/test-debug-brk.js
@refack looks like someone beat me to the punch in #5025. I think this issue is good to close given that the --inspect=0 has now been pushed in v8.1.0.
Activity
bmeck commentedon Sep 2, 2016
I am guessing you would also want/need the url to load up in devtools?
after-ephemera commentedon May 11, 2017
I'd love to take a shot at helping on this. Can someone direct me where to start?
cjihrig commentedon May 12, 2017
@azjkjensen this is probably a good place to start. Allowing 0 here seems to make it work for me, but I didn't run the full test suite, and there could be other nuances.
after-ephemera commentedon May 16, 2017
@cjihrig are you suggesting that I just add a check for if
result == 0or do I need to add the random port logic as well?cjihrig commentedon May 16, 2017
@azjkjensen I was suggesting allowing
result == 0.after-ephemera commentedon May 16, 2017
@cjihrig it looks like that change works, I just need to write a test for it and then I'll make a PR. Is a single test usually sufficient for a change like this? This is my first time contributing so such a large project.
refack commentedon May 16, 2017
Use your judgment, if you can think of more than one relevant situation write more than one test...
Good place to look is at test that already check
--inspector--inspect-brklike test/parallel/test-debug-brk.jsrefack commentedon May 16, 2017
P.S. if #13002 lands, you should add a line there too.P.S. #13002 landed, you should add a line there too.
after-ephemera commentedon Jun 8, 2017
@refack looks like someone beat me to the punch in #5025. I think this issue is good to close given that the
--inspect=0has now been pushed in v8.1.0.refack commentedon Jun 8, 2017
@azjkjensen you snooze you lose (or win depends on your POV) 😉