osx, build: Node v6.3.0 won't build on Clang 3.2 (OSX 10.8 Darwin 12.5.0)

[gibfahn]

• Version: v6.3.0
• Platform: Mac OSX 10.8 (Darwin 12.5.0)
• Subsystem: build

The build is failing on OSX 10.8 but passing on 10.10. It looks like the problem is due to this commit: 4014ecb, which was added in #7157 and backported in #7546. I note that @zbjornson said that:

Tested with gcc/g++ 4.8.3, clang 3.4 and MSVC 2015 (i.e. something like #4284 shouldn't happen here).

But I'm still getting this problem. I assume something similar to #4290 would fix it. @bnoordhuis

Failing machine:

Darwin Kernel Version 12.5.0
$ cc --version
Apple LLVM version 4.2 (clang-425.0.28) (based on LLVM 3.2svn)
Target: x86_64-apple-darwin12.5.0

Passing machine:

Darwin Kernel Version 14.0.0
$ cc --version
Apple LLVM version 6.1.0 (clang-602.0.53) (based on LLVM 3.6.0svn)
Target: x86_64-apple-darwin14.0.0
Thread model: posix

Error:

../src/node_buffer.cc:1193:19: error: use of undeclared identifier '__builtin_bswap16'
      data16[i] = BSWAP_INTRINSIC_2(data16[i]);
                  ˆ
../src/node_buffer.cc:56:30: note: expanded from macro 'BSWAP_INTRINSIC_2'
#define BSWAP_INTRINSIC_2(x) __builtin_bswap16(x)
                             ˆ
  c++ '-D_DARWIN_USE_64_BIT_INODE=1' '-DNODE_ARCH="x64"' '-DNODE_WANT_INTERNALS=1' '-DV8_DEPRECATION_WARNINGS=1' '-DNODE_USE_V8_PLATFORM=1' '-DNODE_TAG="-IBMBuild-"' '-DNODE_HAVE_I18N_SUPPORT=1' '-DNODE_HAVE_SMALL_ICU=1' '-DHAVE_INSPECTOR=1' '-DV8_INSPECTOR_USE_STL=1' '-DHAVE_OPENSSL=1' '-DHAVE_DTRACE=1' '-D__POSIX__' '-DNODE_PLATFORM="darwin"' '-DUCONFIG_NO_TRANSLITERATION=1' '-DUCONFIG_NO_SERVICE=1' '-DUCONFIG_NO_REGULAR_EXPRESSIONS=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=0' '-DUCONFIG_NO_BREAK_ITERATION=0' '-DUCONFIG_NO_LEGACY_CONVERSION=1' '-DUCONFIG_NO_CONVERSION=1' '-DHTTP_PARSER_STRICT=0' '-D_LARGEFILE_SOURCE' '-D_FILE_OFFSET_BITS=64' -I../src -I../tools/msvs/genfiles -I../deps/uv/src/ares -I/build/node/out/Release/obj/gen -I../deps/v8_inspector -I../deps/v8_inspector/deps/wtf -I/build/node/out/Release/obj/gen/blink -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common -I../deps/openssl/openssl/include -I../deps/zlib -I../deps/http_parser -I../deps/cares/include -I../deps/uv/include  -Os -gdwarf-2 -mmacosx-version-min=10.7 -arch x86_64 -Wall -Wendif-labels -W -Wno-unused-parameter -std=gnu++0x -fno-rtti -fno-exceptions -fno-threadsafe-statics -fno-strict-aliasing -MMD -MF /build/node/out/Release/.deps//build/node/out/Release/obj.target/node/src/node_file.o.d.raw   -c -o /build/node/out/Release/obj.target/node/src/node_file.o ../src/node_file.cc
1 error generated.
make[2]: *** [/build/node/out/Release/obj.target/node/src/node_buffer.o] Error 1
make[2]: *** Waiting for unfinished jobs....
rm _node_deps_v8_inspector_platform_v8_inspector_v8_inspector_gyp_protocol_sources_target_generateV8InspectorProtocolBackendSources.intermediate
make[1]: *** [node] Error 2
make: *** [node-v7.0.0-darwin-x64.tar] Error 2

[MylesBorins]

/cc @nodejs/build regarding our OSX testing infra

[mscdex]

I'm not familiar with clang, so I'm not entirely sure which version we should be looking at, but the last version number on the failing machine shows 3.2 which is less than 3.4. shrug

[zbjornson]

Urg. I tested 3.4 because that was the oldest version listed in https://github.com/nodejs/node/blob/master/BUILDING.md. If 3.2 needs to be supported, then we can detect builtin presence and fallback to one of the alternative definitions.

[gibfahn]

@mscdex @zbjornson I had assumed that the clang version was the 425.0.28 (i.e. 4.2), but if it is the 3.2 then our clang level might be out of date.

I think this clang level is the default one for OSX 10.8, which is theoretically supported by node.

[zbjornson]

Apple versions clang kinda unusually. Their 4.2 is based on LLVM 3.2, and their 5.1 is based on LLVM 3.4.

I can work on a patch today, unless the answer is to require people who build to update xcode to a version with LLVM 3.4+ support.

[zbjornson]

@gibfahn when you run ./configure do you get the message "WARNING: C++ compiler too old, need g++ 4.8 or clang++ 3.4 (CXX=clang++)"? I don't have a mac to play with, and I'm facing problems unrelated to 4014ecb trying to get LLVM clang 3.2 to compile node on ubuntu.

[bnoordhuis]

@zbjornson No, no warning. OS X 10.8 with Apple LLVM version 4.2 (clang-425.0.24) (based on LLVM 3.2svn).

For anyone who wants to try it, you have to build with make CXX.host=c++ now because apple's g++ driver doesn't cut it, it doesn't understand the -std=gnu++0x switch.

[bnoordhuis]

Opening gambit: #7644