replServer.setupHistory() silently discards callback errors since v24.2.0 #60837

Activity

1. Renegade334 commented on Nov 24, 2025

   

   Renegade334

   on Nov 24, 2025

   Member

   More actions

   The test cases are reachable. The issue is that setupHistory() is not propagating errors thrown within the callback itself, and is just silently discarding them instead, which is a regression from #58225. (cc @puskin)
2. Renegade334

   added

   replIssues and PRs related to the REPL subsystem.Issues and PRs related to the REPL subsystem.

   on Nov 24, 2025
3. Renegade334

   changed the title [-]Some test cases seem unreachable?[/-] [+]`replServer.setupHistory()` silently discards callback errors since v24.2.0[/+] on Nov 26, 2025
4. wcr-karan

   added a commit that references this issue on Nov 30, 2025

   repl: propagate setupHistory callback errors (fixes nodejs#60837)

   This issue will close once commit 0e8e266 is merged into the 'main' branch.

   0e8e266
5. SudhansuBandha commented on Jun 17, 2026

   

   SudhansuBandha

   on Jun 17, 2026

   Contributor

   More actions

   node/lib/internal/repl/history.js

   Lines 321 to 327 in b09155d

   	this[kContext].once('flushHistory', () => {
   	if (!this[kContext].closed) {
   	this[kContext].resume();
   	onReadyCallback(null, this[kContext]);
   	}
   	});

   
   I have observed since this is an event listener getting called hence the error propagation were not observed. Updating tests to asynchronous pattern is able to catch these assertion errors.

   I have created a PR for this.
   @Renegade334 @puskin
6. SudhansuBandha

   added a commit that references this issue on Jun 22, 2026

   test: update multiline REPL navigation tests for error handling

   ...

   a3e8ca1
7. github-actions commented on Sep 16, 2026

   

   github-actionsbot

   on Sep 16, 2026 – with GitHub Actions

   Contributor

   More actions

   This issue has been marked as stale due to 90 days of inactivity.
   It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.
8. github-actions

   added

   staleIssues and PRs marked stale due to inactivity and scheduled for automatic closure.Issues and PRs marked stale due to inactivity and scheduled for automatic closure.

   on Sep 16, 2026