Skip to content

Use simdjson in JSONParser #59288

@joyeecheung

Description

@joyeecheung

JSONParser predated the inclusion of simdjson, we were using the V8 JSON parser for convenience but it requires more than it needs to do the job (e.g. then the parser cannot be used to parse configs before V8 is initialized, then there's a chicken-and-egg problem if we want to use that to configure how to initialize V8).

node/src/json_parser.h

Lines 28 to 30 in ce8f085

// We might want a lighter-weight JSON parser for this use case. But for now
// using V8 is good enough.
RAIIIsolateWithoutEntering isolate_;

It would be simpler to just use simdjson to do this now that we have it.

Metadata

Metadata

Assignees

No one assigned

    Labels

    c++Issues and PRs that require attention from people who are familiar with C++.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions