REPL started with replServer doesn't persist history

[victorb]

I'm trying to create a REPL via the programmatic library provided by the built-in repl package (https://nodejs.org/api/repl.html).

I'm doing something like this[1]:

var repl = require('repl')
repl.start(' > ')

And I'm expecting the commands I enter to be preserved if I open the repl once again later. Not finding that this is the case, I have been trying to setting both NODE_REPL_HISTORY and NODE_REPL_HISTORY by doing something like this process.env.NODE_REPL_HISTORY = 'somepath'. I've tried setting something to relative path, absolute path, a folder, a file, a non-existing file and a already existing file. But in all cases, the history is not persisted.

I'm not sure if I found a bug or if I'm doing something wrong but would appreciate any I can get.

• Version: v5.8.0 but reproduced the same issue on every version down to v4.0.0, haven't tested lower versions than that...
• Platform: Darwin Mak.localdomain 15.0.0 Darwin Kernel Version 15.0.0: Wed Aug 26 16:57:32 PDT 2015; root:xnu-3247.1.106~1/RELEASE_X86_64 x86_64
• Subsystem: REPL

[1] In reality I'm doing something bigger, https://github.com/victorbjelkholm/trymodule, but figured a small test-case is better for troubleshooting.

[mscdex]

FWIW I would expect programmatic REPLs to have to opt-in as far as saving history goes.

[victorb]

@mscdex That makes sense for me as well, I just would like to be able to enable it somehow, setting the environment variable would be one way, accepting it being set in opts

PS. I can also reproduce this in a docker image (mhart/alpine-node) I frequently use for testing things.

[cjihrig]

@victorbjelkholm what if you pass terminal: true in the REPL options? Looking at the code, it looks like that causes the history to be setup.

[victorb]

@cjihrig Yeah, tried that as well but to no avail 👎

Extended example:

var repl = require('repl')

repl.start({
  terminal: true,
  prompt: '> '
})

[cjihrig]

Ah, yea that is only for the internal REPL, sorry.

[victorb]

@cjihrig saving history in general for programmatic repl or that specific snippet of code? (https://github.com/nodejs/node/blob/master/lib/internal/repl.js#L58-L61)

[victorb]

Seems like one option would be to use the relatively small library repl.history (https://github.com/tmpvar/repl.history) but I would much rather have it in node vanilla.

[cjihrig]

I meant that specific snippet of code that you linked to. It's exported at the top of that file as createInternalRepl(). It looks like it might not be supported for the programmatic REPL at this time.

[victorb]

Oh, I see.

I'll leave this issue open as a feature request to enable history persistence in the programmatic repl and continue my day with using repl.history instead.

Thanks for the help @cjihrig 👍

[Fishrock123]

Imo this is kind of up to the implementor. Maybe we can have it as an option? But it would be a very significant change the programatic API.

[lance]

How big of a change is it really? The createInternalRepl() function just uses a boolean (an odd one, if you ask me[1]) to determine whether or not to call setupHistory(). It seems to me that this function could easily be moved to the public facing repl.js, and triggered on a similar, but probably more aptly named option. E.g. option.history = '/path/to/file.txt'.

It's minor, but there is already a little bleed over from internal to external. I don't see a disadvantage to moving history management into the public API and simply make the createInternalRepl function much simpler - setting up command line defaults and such.

Edit: This is a long way of saying, I'd be willing to submit a PR for this change if there's any chance of it being accepted.

[1] The fact that writing history is a side effect of setting opts.terminal = true seems strange, but I suspect it's a vestige of the fact that this createInternalRepl is secret and only ever used by node.js at startup.