Lack of nullptr check in `src/crypto/crypto_context.cc` `NewRootCertStore`

[wooffie]

Version

20.18.0

Platform

any

Subsystem

crypto

What steps will reproduce the bug?

In this function X509_STORE* store not checked for nullptr. It may cause null pointer dereference.

node/src/crypto/crypto_context.cc

Line 274 in bf59539

X509_STORE* store = X509_STORE_new();

How often does it reproduce? Is there a required condition?

X509_STORE_new returns null

What is the expected behavior? Why is that the expected behavior?

Checking result of X509_STORE_new against nullptr

What do you see instead?

Lack of check

Additional information

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Reporter: Burkov Egor (eburkov@rvision.ru).

Organization: R-Vision (support@rvision.ru).

[wooffie]

Solved in #56700