mksnapshot bus error on mips64el

[kapouer]

Version

22.12.0

Platform

Linux 6.1.0-28-loongson-3 #1 SMP PREEMPT Debian 6.1.119-1 (2024-11-22) mips64el (mips64)

Subsystem

build

What steps will reproduce the bug?

Build on mips64el.
This is a log from a debian build.
I've started a pristine source build to make sure it's not caused by debian package flags, and to get a backtrace.

g++ -o /<>/out/Release/mksnapshot -pthread -rdynamic -EL -mhard-float -Wl,--start-group /<>/out/Release/obj.target/mksnapshot/deps/v8/src/snapshot/embedded/embedded-empty.o /<>/out/Release/obj.target/mksnapshot/deps/v8/src/snapshot/embedded/embedded-file-writer.o /<>/out/Release/obj.target/mksnapshot/deps/v8/src/snapshot/embedded/platform-embedded-file-writer-aix.o /<>/out/Release/obj.target/mksnapshot/deps/v8/src/snapshot/embedded/platform-embedded-file-writer-base.o /<>/out/Release/obj.target/mksnapshot/deps/v8/src/snapshot/embedded/platform-embedded-file-writer-generic.o /<>/out/Release/obj.target/mksnapshot/deps/v8/src/snapshot/embedded/platform-embedded-file-writer-mac.o /<>/out/Release/obj.target/mksnapshot/deps/v8/src/snapshot/embedded/platform-embedded-file-writer-win.o /<>/out/Release/obj.target/mksnapshot/deps/v8/src/snapshot/mksnapshot.o /<>/out/Release/obj.target/mksnapshot/deps/v8/src/snapshot/snapshot-empty.o /<>/out/Release/obj.target/mksnapshot/deps/v8/src/snapshot/static-roots-gen.o /<>/out/Release/obj.target/tools/v8_gypfiles/libv8_base_without_compiler.a /<>/out/Release/obj.target/tools/v8_gypfiles/libv8_init.a /<>/out/Release/obj.target/tools/v8_gypfiles/libv8_libbase.a /<>/out/Release/obj.target/tools/v8_gypfiles/libv8_libplatform.a /<>/out/Release/obj.target/tools/v8_gypfiles/libv8_turboshaft.a /<>/out/Release/obj.target/tools/v8_gypfiles/libv8_abseil.a /<>/out/Release/obj.target/tools/v8_gypfiles/libv8_compiler.a /<>/out/Release/obj.target/tools/v8_gypfiles/libv8_initializers.a /<>/out/Release/obj.target/tools/v8_gypfiles/libv8_initializers_slow.a -lz -luv -lsimdjson -lbrotlidec -lbrotlienc -lcares -lnghttp2 -lnghttp3 -lngtcp2 -lsqlite3 -lcrypto -lssl -licui18n -licuuc -latomic -ldl -lrt -Wl,--end-group
touch 48edd0a62b1829024c3b696f1c1e2e72a6ba670c.intermediate
LD_LIBRARY_PATH=/<>/out/Release/lib.host:/<>/out/Release/lib.target:$LD_LIBRARY_PATH; export LD_LIBRARY_PATH; cd ../tools/v8_gypfiles; mkdir -p /<>/out/Release/obj.target/v8_snapshot/geni; "/<>/out/Release/mksnapshot" --turbo_instruction_scheduling --stress-turbo-late-spilling "--target_os=linux" "--target_arch=mips64el" --startup_src "/<>/out/Release/obj.target/v8_snapshot/geni/snapshot.cc" --embedded_variant Default --embedded_src "/<>/out/Release/obj.target/v8_snapshot/geni/embedded.S" --no-native-code-counters
Bus error

How often does it reproduce? Is there a required condition?

Always

What is the expected behavior? Why is that the expected behavior?

No bus error.

What do you see instead?

Bus error

Additional information

No response

[kapouer]

gdb bt

Starting program: /home/kapouer/node-v22.12.0/out/Release/mksnapshot --turbo_instruction_scheduling --stress-turbo-late-spilling "--target_os=linux" "--target_arch=mips64el" --startup_src "/home/kapouer/node-v22.12.0/out/Release/obj.target/v8_snapshot/geni/snapshot.cc" --embedded_variant Default --embedded_src "/home/kapouer/node-v22.12.0/out/Release/obj.target/v8_snapshot/geni/embedded.S" --no-native-code-counters
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/mips64el-linux-gnuabi64/libthread_db.so.1".
[New Thread 0xfff794f0c0 (LWP 25215)]
[New Thread 0xfff714b0c0 (LWP 25216)]
[New Thread 0xfff69470c0 (LWP 25217)]

Thread 1 "mksnapshot" received signal SIGBUS, Bus error.
0x000000aaab85808c in v8::internal::UnreachableObjectsFilter::MarkingVisitor::VisitPointers(v8::internal::Tagged<v8::internal::HeapObject>, v8::internal::FullObjectSlot, v8::internal::FullObjectSlot) ()
(gdb) bt
#0  0x000000aaab85808c in v8::internal::UnreachableObjectsFilter::MarkingVisitor::VisitPointers(v8::internal::Tagged<v8::internal::HeapObject>, v8::internal::FullObjectSlot, v8::internal::FullObjectSlot) ()
#1  0x000000aaabb4c3ec in v8::internal::HeapObject::Iterate(v8::internal::PtrComprCageBase, v8::internal::ObjectVisitor*) ()

If anyone reading this needs more info, it's really the right time to ask for it - I can't keep the built files forever on that server.

[kapouer]

The gdb backtrace was generated from a pristine nodejs upstream tarball, with default build options.

[kapouer]

Still happening in node 22.14.0, which is to be expected.
v8 12.4.254.21 probably missing some parts of code backport.
For example:

node/deps/v8/src/baseline/mips64/baseline-assembler-mips64-inl.h

Lines 479 to 481 in be79f4a

	void BaselineAssembler::AddSmi(Register lhs, Tagged<Smi> rhs) {
	__ Daddu(lhs, lhs, Operand(rhs));
	}

looks like is missing a test when compared to other archs (and in particular, loongson)

node/deps/v8/src/baseline/loong64/baseline-assembler-loong64-inl.h

Lines 482 to 488 in be79f4a

	void BaselineAssembler::AddSmi(Register lhs, Tagged<Smi> rhs) {
	if (SmiValuesAre31Bits()) {
	__ Add_w(lhs, lhs, Operand(rhs));
	} else {
	__ Add_d(lhs, lhs, Operand(rhs));
	}
	}