-
-
Notifications
You must be signed in to change notification settings - Fork 34.5k
Open
Labels
testIssues and PRs related to the tests.Issues and PRs related to the tests.toolsIssues and PRs related to the tools directory.Issues and PRs related to the tools directory.
Description
It seems recently many flakes are tests that are timing out. In this case, in the CI we usually see nothing but a hint that it is failing because of a timeout. It seems useful to either always run the tests with --trace-sigint, or support re-running the test immediately with --trace-sigint once it times out. (another option would be to use a stress test job separately, but not all configs are supported in stress tests)
Some caveats:
- This may work well enough at least for tests that are not timing out because a child process is timing out. For the child process case, maybe it's useful to implement a dedicated environment variable for this (I think simply using
NODE_OPTIONSmight not be enough since the tests might not be concatenating what's from the environment). --trace-sigintis implemented in JS and is only printing the main thread's JS stack trace. In this use case I think we are very likely to need the native stack traces too, and for all threads.- Maybe an option built into Node.js isn't the most robust approach and we should implement something external for this?
cc @nodejs/build @nodejs/testing @legendecas (who implemented --trace-int)
avivkeller
Metadata
Metadata
Assignees
Labels
testIssues and PRs related to the tests.Issues and PRs related to the tests.toolsIssues and PRs related to the tools directory.Issues and PRs related to the tools directory.