-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
Closed
Labels
deprecationsIssues and PRs related to deprecations.Issues and PRs related to deprecations.v8 engineIssues and PRs related to the V8 dependency.Issues and PRs related to the V8 dependency.
Description
Both updates are trivial:
v8::ScriptOrigin's constructor no longer takes an Isolate (it was already unused)v8::SafeForTerminationScopeand the Isolate creation paramonly_terminate_in_safe_scopeare gone (they were already no-ops)
See v8#185 for the fixes I made to keep V8's CI happy.
cc @joyeecheung
Metadata
Metadata
Assignees
Labels
deprecationsIssues and PRs related to deprecations.Issues and PRs related to deprecations.v8 engineIssues and PRs related to the V8 dependency.Issues and PRs related to the V8 dependency.