Repository navigation
test-buffer-tostring-rangeerror is flaky (timeout) #52964
Description
Activity
I'm able to reproduce locally: running the test 100'000 times, I got 6 timeouts. If I add a
console.log("pass")at the end of the file, it gets printed even when the test times out. Addingprocess.exit();does not help.I also investigated this a bit earlier. I was able to reproduce it quite consistently with just a 1000 runs and reduced it to this:
'use strict'; require('../common'); const assert = require('assert'); const { constants: { MAX_STRING_LENGTH } } = require('buffer'); const len = MAX_STRING_LENGTH + 1; const message = { code: 'ERR_STRING_TOO_LONG', name: 'Error', }; assert.throws(() => Buffer(len).toString('utf8'), message); assert.throws(() => Buffer(len).toString('utf8'), message);
Removing either the second
buffer.toStringcall, the../commonimport, adding aconsole.log('pass')at the end or using a debug build will make it not reproduce anymore. 🙃 🤔Could we try to add
--no-warningsCLI flag and see if that would have any effect? EDIT: nope, I tried with both--no-warningsand--no-deprecation, and I was still getting timeoutsI got curious again by #52959 (comment) and indeed this doesn't reproduce on 07f481c but does on 91661ec so it looks like something in #52293 introduced this flakiness as well / aka probably it's the same root cause.
Reacted by Luigi Pinca@fahrradflucht can you try with the
--jitlessflag?@fahrradflucht can you try with the
--jitlessflag?It indeed does not reproduce with
--jitlesson 91661ec.I got curious again by #52959 (comment) and indeed this doesn't reproduce on 07f481c but does on 91661ec so it looks like something in #52293 introduced this flakiness as well / aka probably it's the same root cause.
Actually, I'm sorry, I think I have to take this back. I now reproduced a bunch of times on 07f481c as well. It might happen less prior to the v8 update, but it can be reproduced as well.
what environment did you guys reproduce it locally? @aduh95 @fahrradflucht
This issue has been marked as stale due to 210 days of inactivity.
It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.This issue has been automatically closed after 30 days of inactivity following its stale status (no activity for a total of 240 days).
If this is still relevant, feel free to reopen it or leave a comment with additional details so we can continue the discussion.
Test
test-buffer-tostring-rangeerrorPlatform
Linux x64
Console output
Build links
Additional information
No response