Repository navigation
V8 CI build error on ppc #52661
Description
Activity
- addedbuildIssues and PRs related to Node.js builds or CI infrastructure.Issues and PRs related to Node.js builds or CI infrastructure.v8 engineIssues and PRs related to the V8 dependency.Issues and PRs related to the V8 dependency.ppcIssues and PRs related to the Power architecture.Issues and PRs related to the Power architecture.
on Apr 24, 2024 This doesn't happen on our gcc 12 compilers, i'm assuming you are using 10 for ppc? probably related to this bug:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86465Yes, we're currently still using gcc-10 and C++17 (
-std=gnu++17. for Node.js). The V8 build is running with-std=gnu++2a(C++20).FWIW I've been experimenting with gcc-toolset-12 in richardlau-node-test-commit-v8-linux. The build on
mainfrom yesterday (today's is still in progress) succeeded with gcc 12: https://ci.nodejs.org/job/richardlau-node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/589/Reacted by Michael DawsonI ran some Node.js builds based on
main(91dc8c9) plus commits to use C++20 but these still succeed with gcc-toolset-10:-std=gnu++20(ref: build: compile with C++20 support #45427): https://ci.nodejs.org/job/node-test-commit-plinux/53061/-std=gnu++2a(same as the V8 CI): https://ci.nodejs.org/job/node-test-commit-plinux/53063/
so there's some other flag difference between the V8 and Node.js builds causing the compilation error to show up in the V8 one but not in the Node.js one when gcc-toolset-10 is used.
Isn't the main difference that V8 builds use Clang?
Isn't the main difference that V8 builds use Clang?
AFAIK not on ppc64le. You can see in the quoted compile failure in #52661 (comment) that it's executed
ccache g++which would be gcc from the gcc-toolset we select inselect-compiler.sh.The reason the Node.js V8 CI fails with gcc 10 but the Node.js CI does not is because the V8 build passes
-Werrorand-Wallto enable all warnings (with additional flags to turn some of the warning off) and fail on error while the Node.js build does not. Adding-Wallor just-Wuninitializedto the Node.js compile command line flags the same warning, and adding-Werrorcauses the build to fail.This may be related to https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86465. Dropping optimization to a lower level makes the warning go away (i.e. we get the warning with
-O3but not-O2or-O1).@miladfarca has submitted https://crrev.com/c/5503350 upstream which also makes the warning go away.
https://ci.nodejs.org/job/node-test-commit-v8-linux/5950/ passed with 2c30d3d.- added a commit that references this issue
on May 3, 2024 - added a commit that references this issue
on May 8, 2024 - added a commit that references this issue
on May 22, 2024 - added a commit that references this issue
on Jun 20, 2024
@nodejs/platform-ppc
We missed it in the 12.4 upgrade PR.
https://ci.nodejs.org/job/node-test-commit-v8-linux/5914/nodes=rhel8-ppc64le,v8test=v8test/